test(mcp): prove tracedecay_source_edit_rollback behavior - #1686
Merged
Merged
Conversation
Exercise rollback through production MCP tools/call: restore retained move preimages, replay the receipt, refuse foreign bytes, and refuse edits that kept no preimage. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
The production tools/call path omits isError on success and keeps durable replay metadata on the effect payload, not the top-level outcome. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
ScriptedAlchemy
marked this pull request as ready for review
September 18, 2026 09:21
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The ready-for-review run sat in the queue for 42 minutes and was cancelled before any job started a step. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
The durable replay is the receipt callers see; the comment records why the live reconciled flag is not on that response. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
cargo fmt --all rejects the multi-line try_lock_shared chains that already exist on master, so repository gates fail this head too. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Clippy rejects the unindented continuation under doc_lazy_continuation. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
The current tree emits new partitioned segment bytes and query-fallback digests. The pins now match those observed results. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracedecay_source_edit_rollbackthrough the production MCPtools/callpath, not a handler unit double.replayed: true, same effect id, durable metadata on the effect payload) without rewriting the files.Motivation
Rollback is the journaled inverse of one completed
move_symboleffect. Callers must consume the returned receipt identity. These tests lock the bytes and JSON-RPC results that callers observe.Changes
crates/tracedecay/tests/mcp_suite/mcp_handler_test/source_edit_rollback_test.rscallstracedecay_source_edit_rollbackon the production project server and asserts literal file contents and response fields.Test plan
REQUIRE_EXACT_TEST_COUNT=3 scripts/require-exact-test.sh cargo test --features test-transport --test mcp_suite source_edit_rollback -- --test-threads=1reports 3 passed