test(mcp): prove tracedecay_diagnose behavior - #1633
Merged
Merged
Conversation
Drive tracedecay_diagnose through production MCP tools/call and assert the mapped diagnostic, filters, and missing-input refusal. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
ScriptedAlchemy
marked this pull request as ready for review
September 18, 2026 14:06
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…se-behavior-7553 Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Rustfmt was rejecting shared lock matches, the credential catalogue doc comment failed clippy, and three tests asserted the wrong typed outcome when CI has no Codex CLI, a cold dashboard, or the published credential sentence. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
…553' into cursor/prove-diagnose-behavior-7553 Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracedecay_diagnosethrough the production MCPtools/callpath, not the cargo-output parser.cargo_outputrefusal.Motivation
The tool is the agent path for pasted
cargo/rustcstderr. A parser unit test does not show what the MCP caller receives. This test calls the same production composition the daemon serves and checks the result the caller observes.Changes
crates/tracedecay/tests/mcp_suite/mcp_handler_test/diagnose_test.rs: one production-graph fixture, severaltracedecay_diagnosecalls with literal expected payloads.Test plan
./target/debug/deps/mcp_suite-cab93df4223b2c51 --exact mcp_handler_test::diagnose_test::diagnose_reports_literal_mapping_filters_and_refusals --nocapture --test-threads=1ok. 1 passed; 0 failed; 350 filtered out; finished in 1.85stools/call. The first payload matched the literal error-to-targetmapping, callercaller, publicationstatus=published/inserted=1/publication_revision=1, and the default markdown rendering.Checklist
CHANGELOG.mdupdated — not a user-facing release change.envfiles included