fix(surface): name the field a refused application request failed on

[ScriptedAlchemy]

Summary

• Dogfooding every tool on beta.40, 31 tools answered application surface request does not match its reviewed schema with no field named. configuration_get --key nope, git_diff --base HEAD~1, and code_implementations with a wrong selector all produced the same opaque line.
• ApplicationSurfaceAdapterError::InvalidSurfaceRequest now carries detail. Serde decode errors flow through one invalid_request helper, hand-written checks name the field, and the HTTP/MCP problem envelope repeats the detail. The detail echoes only the caller's own request.

Test plan

• cargo test -p tracedecay-daemon-service --lib application_surface::tests 38 passed (cc-23380)
• Real journey on this host after install: tracedecay tool configuration_get --key nope names the key

[changeset-bot]

⚠️ No Changeset found

Latest commit: 729ca26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

[github-actions]

Performance Comparison master → fix/surface-request-detail

Total Elapsed Time: 7.56s → 7.50s (-0.8%)
CPU Baseline: 89.22µs → 88.97µs (-0.3%)
Benchmark ID: index-bench-timing

timing - Execution duration of functions.

+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| Function                                 | Calls                      | Avg                            | P95                            | Total                          | % Total                      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| tracedecay-index-bench                   | 1 → 1 (+0.0%)              | 7.56s → 7.50s (-0.8%)          | 7.57s → 7.50s (-0.9%)          | 7.56s → 7.50s (-0.8%)          | 100.00% → 100.00% (+0.0%)    |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| domain.canonical.sha256                  | 72891 → 72891 (+0.0%)      | 33.09µs → 32.92µs (-0.5%)      | 108.16µs → 108.22µs (+0.1%)    | 2.41s → 2.40s (-0.4%)          | 31.89% → 31.98% (+0.3%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.workers.install               | 30 → 30 (+0.0%)            | 76.75ms → 76.33ms (-0.5%)      | 212.73ms → 203.55ms (-4.3%)    | 2.30s → 2.29s (-0.4%)          | 30.44% → 30.52% (+0.3%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.sqlite              | 5 → 5 (+0.0%)              | 363.93ms → 362.60ms (-0.4%)    | 401.34ms → 400.03ms (-0.3%)    | 1.82s → 1.81s (-0.5%)          | 24.06% → 24.16% (+0.4%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.finalization.advance_wake | 28 → 28 (+0.0%)            | 51.64ms → 50.72ms (-1.8%)      | 406.59ms → 402.92ms (-0.9%)    | 1.45s → 1.42s (-2.1%)          | 19.12% → 18.93% (-1.0%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.postings            | 5 → 5 (+0.0%)              | 268.61ms → 269.13ms (+0.2%)    | 302.78ms → 301.99ms (-0.3%)    | 1.34s → 1.35s (+0.7%)          | 17.76% → 17.94% (+1.0%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.extract.parser_artifact       | 276 → 276 (+0.0%)          | 4.12ms → 4.15ms (+0.7%)        | 6.65ms → 6.78ms (+2.0%)        | 1.14s → 1.14s (+0.0%)          | 15.03% → 15.26% (+1.5%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.build.and_publish             | 2 → 2 (+0.0%)              | 552.85ms → 550.75ms (-0.4%)    | 1.03s → 1.03s (+0.0%)          | 1.11s → 1.10s (-0.9%)          | 14.62% → 14.68% (+0.4%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.parallel_prepare    | 5 → 5 (+0.0%)              | 186.16ms → 184.38ms (-1.0%)    | 212.73ms → 203.55ms (-4.3%)    | 930.82ms → 921.92ms (-1.0%)    | 12.31% → 12.29% (-0.2%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| domain.canonical.json_bytes              | 206681 → 206681 (+0.0%)    | 4.19µs → 4.24µs (+1.2%)        | 4.40µs → 4.43µs (+0.7%)        | 865.22ms → 877.01ms (+1.4%)    | 11.44% → 11.69% (+2.2%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.restore.file_admit            | 260 → 260 (+0.0%)          | 3.13ms → 3.11ms (-0.6%)        | 5.08ms → 5.10ms (+0.4%)        | 813.39ms → 808.82ms (-0.6%)    | 10.75% → 10.78% (+0.3%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| query.artifact.batch.postings.ngram_rows | 5 → 5 (+0.0%)              | 152.65ms → 154.20ms (+1.0%)    | 171.05ms → 171.84ms (+0.5%)    | 763.24ms → 771.02ms (+1.0%)    | 10.09% → 10.28% (+1.9%)      |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.build.materialize_full        | 1 → 1 (+0.0%)              | 724.85ms → 724.31ms (-0.1%)    | 725.09ms → 724.57ms (-0.1%)    | 724.85ms → 724.31ms (-0.1%)    | 9.58% → 9.65% (+0.7%)        |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.collect.materialize_full      | 1 → 1 (+0.0%)              | 718.80ms → 718.40ms (-0.1%)    | 718.80ms → 718.80ms (+0.0%)    | 718.80ms → 718.40ms (-0.1%)    | 9.50% → 9.58% (+0.8%)        |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+
| code_index.restore.file_decode           | 260 → 260 (+0.0%)          | 2.01ms → 1.98ms (-1.5%)        | 3.16ms → 3.03ms (-4.1%)        | 523.04ms → 515.73ms (-1.4%)    | 6.92% → 6.87% (-0.7%)        |
+------------------------------------------+----------------------------+--------------------------------+--------------------------------+--------------------------------+------------------------------+

---

Generated with hotpath-rs