ci(release): run the Linux release battery on the release PR - #1559
Merged
Merged
Conversation
The battery only re-applied git patches for the extracted crate trees. The vendored hotpath-macros path patch was dropped, so every isolated feature check resolved it against crates.io offline and the beta.40 asset builds failed.
Twelve beta tags published with zero assets because distribution acceptance first ran after release-please had already tagged and published. The release PR now runs the same x86_64-linux steps, so a tree that cannot ship never gets a tag.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Census of every beta tag (
bash /tmp/td-dogfood/release-census.sh, reproducible withgh): 12 tags, 0 assets each. The killer step isRun distribution acceptance(or a sibling release-only step) every time, and it runs only after release-please has tagged and published the prerelease. PR CI never exercises those steps, so a green PR never meant a shippable tree.This removes the ordering asymmetry instead of fixing one more defect: the
chore(release)PR runs the same x86_64-linux steps asrelease-beta.yml(dashboard build, harness validation, release distribution tests, all-feature compile, offline distribution acceptance with the lockfile invariant). A tree that fails them is blocked before the tag exists.Follow-up decision for the repo owner: mark
Release PR distribution acceptance (x86_64-linux)as a required status on master and the beta branch sogh pr mergecannot bypass it.Test plan