fix(runtime): settle Fresh without false Verifying; dirty seat Noop - #1543
Closed
ScriptedAlchemy wants to merge 1 commit into
Closed
ScriptedAlchemy wants to merge 1 commit into
ScriptedAlchemy wants to merge 1 commit into
Conversation
Dashboard freshness treated a bare pending wake as refresh_in_flight, so Fresh flipped to Verifying between settled status samples. Dirty remount seating required an already-decoded generation, so a held decode barrier returned None instead of a pointer Noop. Keep quiet undecoded seats from claiming currency while allowing dirty pointer Noops without joining the decode flight, and wait for owner quiescence before declaring ready. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not landing.
The dirty-seat Noop would report a snapshot identity this pass did not decode. Current seating already uses active_already_decoded and refuses a quiet Noop unless sealed digests match. The deadlock this draft describes, joining load_active_shared, is not in that function anymore.
Dropping pending_wake from Verifying is unproven. The only test change re-samples a wait helper. A scheduled wake is not the same as an executing proof, and this draft does not show a settled seat that wrongly flips Fresh to Verifying.