fix(daemon): decode partitioned sealed gens in fan-out wait - #1541
Merged
Merged
Conversation
Monolithic decode_sealed rejected partitioned manifests on disk, so mounted_fan_out timed out waiting for a generation that already existed. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mounted_fan_out_recovers_then_synthesizes_and_hands_offtimed out inwait_for_code_generationeven when the active generation pointer and file were already on disk.decode_sealed, which rejects partitioned manifests the daemon publishes undercode-generation-segments-v1.read_active_code_generationto usedecode_partitioned_sealed(same pattern asindexing_lifecycle_test) and enrich the timeout assertion with pointer/segment diagnostics.Test plan
scripts/require-exact-test.sh cargo test --features test-helpers --test daemon_suite advanced_workflow_journey_test::mounted_fan_out_recovers_then_synthesizes_and_hands_off -- --exact --nocapturePost-#707 master fix. Does not touch campaign branch.