fix(knowledge): finish lookbook V2 facts camera on the #707 tip - #1540
Closed
ScriptedAlchemy wants to merge 5 commits into
Closed
ScriptedAlchemy wants to merge 5 commits into
ScriptedAlchemy wants to merge 5 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Owner
Author
|
Integrated directly on #707; dashboard typecheck and the full 205-file / 1,980-test suite pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #1522, whose first three commits were integrated onto this branch at
97f6cff320/4feafbf97a/d157d57baf. This PR carries the remaining Knowledge (ch 07,/knowledge) work from the same run, rebased on the current tip, plus one refactor onto the shell mechanism that landed here in the meantime:lg, and the sort control moves onto the ledger's title bar. Belowlgthe camera stacks at natural height so the summary bay can no longer paint through the field.MEMORY,GRAPH,CAMERA— through the canonicalusePublishStatusRegistersthat now exists on this branch, and delete the workspace-owned register row that duplicated it; the overview envelope's coverage/freshness/refresh returns to the canonicalEnvelopeTruthheader.Changes
dashboard/src/workspaces/knowledge/knowledgeRegisters.ts(+ test) — pure register builders (memoryRegister,graphRegister,cameraRegister); a sub-read state never outranks the envelope that carries it.KnowledgePage.tsx— publishes registers (knowledge,knowledge:facts), restoresEnvelopeTruth, natural-height stack belowlg, sort control on the ledger title bar.FactConstellation.tsx— field heightclamp(180px, 30vh, 360px), side key fromlg, dims only for inspection (selection is a ring),onPointerMove.FactLedger.tsx—FactSortControlexport, compact slice statement, selected-row scroll sync within the ledger scroller.FactInspector.tsx— wrapper carries the test hooks;retrievals/accessesas separate terms; wrapping term column.constellation.ts— label collision pass.ui/archetypes/ExplorerSplit.tsx—DataRow.onInspectfires ononPointerMove+onFocus; newrowId→data-row-id.ui/StateChip.tsx— drops thestateLampClasshelper (its only caller was the deleted register row;STATE_LAMPstays).KnowledgeRegister.tsx.Test plan
npm run typechecknpm test— 185 files / 1811 tests green on this tipnpm run build+scripts/check-dashboard-bundle.py/fact/request and dims unrelated bodies; click writes?fact=and reads detail + audit; reload reopens; arrows move focus and inspection together; Enter selects; Escape unwinds inspection then selection; sort/query in the address; ledger row scrolled into view on field selection without moving the page; touch ≥ 44px and no horizontal overflow at 1440 / 768 / 320 / 200%; reduced motion pins transitions and removes scanlines; summary bay stacks below the field on narrow viewports;MEMORY ready,GRAPH partial,CAMERA Factson the shell strip; no page errors.a7eda47dc2, embedded dashboard):daemon run,inita registered project, 7 ×tool fact_store_add, 3 ×tool fact_feedback,dashboard --port 5299— 12/12 checks: 7 rows for 7 daemon facts; 7 bodies from a 19-node / 16-edge verified graph; strip showsLINK live · MEMORY ready 7 facts · GRAPH ready 7 roots · 16 relations · CAMERA Facts; canonical detailreadywith linked entities;complete_zero_findingsaudit for an unrated fact; a 2-event trace for the rated one (the third feedback was an idempotent replay — the inspector shows the store's 0.85, not a fabricated 0.95); no page errors.cargo nextest/cargo clippy— not run (no Rust changes)Checklist
CHANGELOG.mdupdated.envfiles includedDataRowadditions are optional;stateLampClasshad no other caller)Gaps against the plate (typed, not hidden)
repo/path/observed in N commits— no repository or path authority is joined to memory facts; the inspector says so and shows free-formmetadataas data.first seen/last seen— rendered as the real fieldscreated,updated,last recalled,projected as of.source verified,symbol resolved,doc extracted,tests observed,runtime observed) — no verification authority is served; the rung isunavailablewith the reason. Geometry membership isunknownon Facts.memory_api::overviewserves one trust-ranked slice,limit ≤ 100, no cursor. The ledger states the bound and the count beyond it; server paging is a backend gap.IMPLEMENTATION.md; density is bounded by the daemon's graph limit; labels are budgeted with collision avoidance; no client-side clustering for thousands of roots.mentions+active_assertiononly.dashboard/audit-baselines/knowledge__*.pngdrift (harness not in CI); not re-baselined — Playwright's own Chromium is not installed here, system Chrome was used.