fix(explorer): V2 lane follow-ups — reflow, freshness, scope register - #1539
Closed
ScriptedAlchemy wants to merge 6 commits into
Closed
ScriptedAlchemy wants to merge 6 commits into
ScriptedAlchemy wants to merge 6 commits into
Conversation
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Owner
Author
|
Integrated directly on #707; dashboard typecheck and the full 205-file / 1,980-test suite pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Explorer V2 four-lane surface integrated on this branch at
a685d76c8c/9ed305827d(from the closed #1523). These five commits were verified in the browser after that integration and are not on the tip yet:lg(320px, 768px, 200% zoom):1frrows collapsed under the lane minimum. Lanes now stack at a fixed row height and the aperture scrolls. Lane headers put the name over the state chip so the four headers align regardless of detail length; hover gains the one restrained halo the design system calls for.freshnessword and (clipped)watermark; the count row carries the shared pattern axis (measuredwhen a real total was reported,associatedwhen not).Locked · no run created: the scope is read-only/Unknown …instead ofLoading · admitting the source planforever.Motivation
The lookbook brief's release gates include 200% zoom, dense data, and reduced motion. The overlap and overflow were real gate failures visible in the production bundle; the register and freshness items are truth gaps (a run that will never be created shown as loading; a served page with no statement of how current it is).
Changes
Lane.tsx: header restructure,LaneGridresponsive rows (lg:auto-rows-fr/max-lg:auto-rows-[28rem]), hover halo + explicit focus outline,EvidencePatternon the count row, footer freshness/watermark (clipped, full value ontitle).laneModel.ts:freshness/watermarkonready/partial(source progress, or envelope freshness for browse reads).controller.ts: exposeswritability.panels.tsx:RunRegisterrenders the scope refusal when no run exists.ExplorerPage.tsx:FilterSelectgetsname+max-w-[10rem].laneModel.test.ts(freshness),evidence.test.ts,ExplorerPage.dom.test.tsx(register refusal, freshness attribute).Test plan
npm run typecheck(dashboard) passesnpm test(dashboard): 184 files / 1808 tests pass on this tipnpm run build(dashboard) passesapp-dist, browse fixtures + scripted coordinator): 60/60 checks — including no lane overlap and no horizontal overflow at 768 / 320 / 200% zoom, reduced motion, light theme, locked register under a read-only scope, zero page/console errors.tracedecay daemon run+tracedecay dashboardon an indexed 299-file sample): 4 exact code rows forsemanticLane,fresh @ generation.v1.8cb7763b.0000…in the footer, hover peek with zero extra reads, selection with real symbol id andOpen symbol in Codelink.cargo nextest run --workspace --no-fail-fast— no Rust changescargo clippy— no Rust changesChecklist
CHANGELOG.mdupdated — N/A, generated at release.envfiles included320px: lanes stack without overlap
Read-only scope: locked lanes and a locked run register, nothing dispatched
Live daemon: 4 exact code rows, fresh watermark, sessions and knowledge served empty, semantic unregistered
To show artifacts inline, enable in settings.