Repository navigation
refactor: encode duplicated contracts in their owning authorities - #1515
Closed
ScriptedAlchemy wants to merge 2 commits into
Closed
ScriptedAlchemy wants to merge 2 commits into
ScriptedAlchemy wants to merge 2 commits into
Conversation
Hand-maintained copies of the SQLite schema, response budget, and native staging page size were kept in sync by comments. Read them from the owning inventory or constant, and refuse hint specs whose credited tools are not exact tokens in the hint text. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
…r/encode-lessons-in-structure-095a Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tracedecay://schemamarkdown (and its "keep in sync" comment) with the migration inventory this binary actually admits.MAX_RESPONSE_CHARSandMAX_NATIVE_GENERATION_STAGE_MUTATIONS.tracedecay_context/searchno longer counts astracedecay_search).Principle: encode-lessons-in-structure.
Motivation
PR #707 repeated the same lesson as comments ("keep in sync", "mirrors X", "update both together") next to a second copy. Those copies had already drifted: the schema resource still documented a deleted
nodes/edgesgraph, and two hint categories credited tools the prose did not name.This PR lands into
codex/tracedecay-total-redesign-plan-reopened(PR #707 tip). It does not targetmaster.Merged tip:
3e6167b265639c17b7d1c174cd3b7baa3116adae.Merge commit:
8085b801afc4d33a3027865af5424e49fd9bf60c.Conflicts: none (ort merge).
The tip already compiled the
NotApplicableadmission arm and stopped walking the removedchanges.reusedlist. Those fixes are in the merged tree andtracedecay-code-index-runtimebuilds.Changes
crates/tracedecay-runtime-core/src/db/migrations/final_shape.rsrenders schema markdown from the admissionsqlite_masterinventory.tracedecay://schemaserves that render. The resource description no longer promises a hand-written recipe book.MAX_NATIVE_GENERATION_STAGE_MUTATIONS. Response-budget tests importMAX_RESPONSE_CHARS.HintCategorySpec::checked. Project-context prose namestracedecay_search; atomic-edit prose namestracedecay_move_symbol.Test plan
cargo test -p tracedecay-runtime-core --lib db::migrations::final_shape::render_tests::rendered_schema_markdown_is_the_admission_inventory -- --exact— 1 passedcargo test -p tracedecay --lib mcp::server::rmcp::tests::legacy_json_rpc_wire_frames_are_unchanged_by_the_typed_envelope -- --exact— 1 passed (resource body equals the inventory)cargo test -p tracedecay-agent-hosts --lib hooks::tool_hints::expected_tool_token_tests::slash_joined_shorthand_does_not_name_the_second_tool -- --exact— 1 passed (also type-checks every hint spec)handlers::analysis::circular::circular_render_tests) — 2 passedcargo test -p tracedecay-graph-db --lib generation_runtime::tests::native_generation_stages_sixty_five_thousand_rows_in_one_durable_page -- --exact— 1 passedcargo test -p tracedecay-graph-db --features test-helpers --test graph_db_suite a_partially_released_generation_is_repaired_from_its_manifest_and_swept --no-run— compiledcargo test -p tracedecay-code-index-runtime --lib code_index_scheduler::tests::publication_store::generation_decode_shares_the_store_and_waits_for_an_exclusive_writer -- --exact— 1 passed after absorbing the tipChecklist
.envfiles includedCHANGELOG.mdupdated — not a user-facing release note; schema resource now describes the live inventorytracedecay://schemabody is no longer the old graph recipe; it is the admitted DDL