Repository navigation
fix: refuse non-final schemas instead of cutover shims - #1503
Closed
ScriptedAlchemy wants to merge 4 commits into
Closed
ScriptedAlchemy wants to merge 4 commits into
ScriptedAlchemy wants to merge 4 commits into
Conversation
The family schema is the only current similar/redundancy contract. Retired shapes and field aliases were cutover compatibility, not a delegating released facade. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Published v3 and unreleased pre-recovery v4 stores return ResetRequired before conversion. Only the final temporal shape is admitted. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
|
…plan-reopened' into cursor/outcome-oriented-execution-aacd Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Equal length and mtime are not the incumbent pointer. A same-size restore inside one timestamp quantum was refused as CompareAndSwap. Co-authored-by: Zack Jackson <ScriptedAlchemy@users.noreply.github.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3e6167b265(test(code-index): re-pin partitioned codec onto extractor.rust.v8) into this branch. Merge commitec0a39987c. No conflicts.ResetRequiredbefore conversion.CodeIndexDemandAdmissionV1::NotApplicable, missingreusedonChangedCodeChunkSetV1) are absorbed from the tip and no longer reproduce.CompareAndSwap.This PR targets
codex/tracedecay-total-redesign-plan-reopenedonly. It does not merge #707 or this branch to master.Motivation
Plan 12 / Plan 21 say source-only aliases and earlier persisted shapes change in place or return
ResetRequired. Cutover decoders and unreleased store conversions are transitional stability, not the end state.The publication memo violated the same rule the scheduler already states for source freshness: equal length and mtime are a negative cache, not proof of currency.
Changes
crates/tracedecay-contracts/ MCP handlers: family schema is the only similar/redundancy wire. Protocol range is 1..=1.crates/tracedecay-global-db: delete v3 and pre-recovery v4 conversions.ResetRequiredbefore mutation.publication_store.rs: compare the pointer digest before memo reuse. The failing test now restores the observed identity under a preserved mtime.Findings not changed
Left in place so this PR stays one end-state cut:
tracedecay-runtime-corestill converges released v34/v35 project stores in place.code_projectsstill adds primary-root columns for the released 8-column shape.migrate_retired_mutation_copy_tablesstill rewrites retired external-source rows.Test plan
cargo test -p tracedecay-mcp --lib clone_lanes_report_one_unavailable_wire_protocol— pass (previously blocked by the tip compile errors; those are gone)cargo test -p tracedecay-code-index-runtime --lib publication_store::— 27 passed, includingpublication_over_an_undecodable_active_generation_refuses_a_moved_pointerafter the digest fixcargo test -p tracedecay-contracts --lib similar_and_redundancy_reject_retired_request_shapes— passcargo test -p tracedecay-contracts --test contracts_suite similar_and_redundancy_keep_one_current_protocol_revision— passcargo test -p tracedecay-global-db --lib admission::— 30 passed[Unreleased]section to editChecklist
.envfiles included