Skip to content

test(mcp): status and context pins read a transient verifying state #2356

Description

@ScriptedAlchemy

Two mcp_suite tests fail intermittently on origin/master (reproduced at 8190d4f with every crate at master; 8 of 10 isolated runs failed one or both):

cargo test -p tracedecay --locked --features test-transport,test-helpers --test mcp_suite -- \
  context_related_order_test::context_ranks_related_symbols_before_the_cut_and_reports_the_omission \
  status_behavior_test::tracedecay_status_reports_the_sealed_branch_and_keeps_diagnostics_opt_in
  • status_behavior_test::tracedecay_status_reports_the_sealed_branch_and_keeps_diagnostics_opt_in panics at status_behavior_test.rs:275 (owner bullet JSON: Error("expected ident", line: 1, column: 2)): the markdown carries a non-JSON - bullet, the freshness warning status renders while code_index_freshness is not current.
  • context_related_order_test::context_ranks_related_symbols_before_the_cut_and_reports_the_omission fails at support.rs:373: freshness is {"indexing": {..., "staleness_state": "verifying", "rebuild_in_flight": false, served_generation == latest_generation ...}} where the test expects {"state": "fresh"}.

Both see the same state: the served generation is the latest one, no rebuild is in flight, and the fence is re-verifying source (verifying). The same two tests passed 582/582 in a full run at d0d4d3a earlier today, so the change is recent. #2341 (f3f7e04ea0, fresh verifies at request time) is the likely origin. Either the fixtures must await a verified proof before pinning fresh, or a request-time verification should not leave a settled, unchanged worktree reading verifying.

Found while landing the master-red bundle for #2313, #2333, #2336 and #2344; not changed there.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions