scripts/neutralize-release-pr-closing-keywords.py (added in 5ad8106) does not match the form release-please actually writes into release PR bodies: a closing keyword followed by a markdown-linked reference, e.g.
..., closes [#2231](https://github.com/ScriptedAlchemy/tracedecay/issues/2231)
The regex requires the reference to start immediately after the keyword (#\d+, owner/repo#\d+, or a bare issues URL), so the [ defeats it.
Reproduction (on master at 2a1598f):
$ printf 'closes [#2231](https://github.com/ScriptedAlchemy/tracedecay/issues/2231)\n' | python3 scripts/neutralize-release-pr-closing-keywords.py
closes [#2231](https://github.com/ScriptedAlchemy/tracedecay/issues/2231)
Evidence: the #2306 (1.0.0-beta.57) body still had closes [#2231](...) and closes [#2308](...) after running scripts/neutralize-release-pr-closing-keywords.sh against it (exit 0, no edit). Both lines were rewritten to Refs [#N](...) by hand before merging. Both issues were already closed, so nothing was wrongly closed this time.
scripts/test-neutralize-release-pr-closing-keywords.py exercises only bare #N / owner/repo#N / URL forms, so it passes; the release-please markdown-link form should be added to it as a literal case.
scripts/neutralize-release-pr-closing-keywords.py(added in 5ad8106) does not match the form release-please actually writes into release PR bodies: a closing keyword followed by a markdown-linked reference, e.g.The regex requires the reference to start immediately after the keyword (
#\d+,owner/repo#\d+, or a bare issues URL), so the[defeats it.Reproduction (on master at 2a1598f):
Evidence: the #2306 (1.0.0-beta.57) body still had
closes [#2231](...)andcloses [#2308](...)after runningscripts/neutralize-release-pr-closing-keywords.shagainst it (exit 0, no edit). Both lines were rewritten toRefs [#N](...)by hand before merging. Both issues were already closed, so nothing was wrongly closed this time.scripts/test-neutralize-release-pr-closing-keywords.pyexercises only bare#N/owner/repo#N/ URL forms, so it passes; the release-please markdown-link form should be added to it as a literal case.