feat!: port prop to effect/unstable/arbitrary (effect rc.113+) - #5
Merged
Merged
Conversation
Effect removed effect/testing/FastCheck in 4.0.0-rc.113 (Effect-TS/effect#7254). Mirror upstream @effect/vitest: prop inputs are Schema | Arbitrary.Arbitrary, the fastCheck option becomes arbitrary?: Arbitrary.CheckOptions, and checks run through Arbitrary.checkEffect so falsified properties shrink and timeouts interrupt the property fiber. Peer effect is now ^4.0.0-rc.113.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ScriptedAlchemy
added a commit
to ScriptedAlchemy/agent-bundle
that referenced
this pull request
Sep 25, 2026
…rc.117 re-pin steps - effect-rstest preview cbbf87e (ScriptedAlchemy/effect-rstest#5) replaces e5f8d5f, which imported the removed effect/testing/FastCheck. - docs/effect-conventions.md: rc.117 pins, subtree from the release tag, re-verified platform/terminal/schema rows, lift the stream-backed derived-atom ban (Effect-TS/effect#7535 shipped in rc.113), bundle and scaffolder measurements, parked rows. - agent-patterns: v4 has no Layer.scoped; Stream header to rc.117. - measure-hook-cold-start: record the pinned effect version.
ScriptedAlchemy
added a commit
to ScriptedAlchemy/agent-bundle
that referenced
this pull request
Sep 25, 2026
Move effect, @effect/atom-react, @effect/platform-node, and @effect/platform-node-shared from 4.0.0-rc.112 to 4.0.0-rc.117 in lockstep and pull the repos/effect subtree to the effect@4.0.0-rc.117 tag. Pin effect-rstest to the pkg.pr.new preview of ScriptedAlchemy/effect-rstest#5 (cbbf87e), which ports prop off the effect/testing/FastCheck module removed in rc.113. Finish re-pin steps 2 and 4-6: lift the stream-backed derived-atom ban (Effect-TS/effect#7535), re-verify unstable-module rows, refresh agent-patterns, record bundle, scaffolder, and cold-start measurements. git-subtree-dir: repos/effect git-subtree-split: 14a3f140095fdebbff9162944fe7d4ea83e054e6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effect removed
effect/testing/FastCheck(and itsfast-checkdependency) in4.0.0-rc.113("Native Arbitraries", Effect-TS/effect#7254). Every currenteffect-rstestbuild imports it at module top level, so importingeffect-rstestfails on any Effect RC after rc.112.This mirrors the same change in upstream
@effect/vitest(rc.117 tag):propinputs areSchema.Schema | Arbitrary.Arbitraryfromeffect/unstable/arbitrary; schemas compile withArbitrary.schema.fastCheck?: FC.Parametersoption is replaced byarbitrary?: Arbitrary.CheckOptions({ runs, seed, maxDiscards, maxShrinks, size, replay }). FastCheck arbitraries are no longer accepted.Arbitrary.checkEffect: returningfalse, throwing, or failing the Effect falsifies and shrinks; interruption still interrupts; the test timeout interrupts the check fiber and finalizers run.effectis now^4.0.0-rc.113; dev pin4.0.0-rc.117.test/prop-failure.test.ts) asserting falsified properties fail, shrink to the same values upstream expects ([8, 1]), and release resources on timeout. README migration note added.Local checks (effect 4.0.0-rc.117):
pnpm checkpass,pnpm test10 files / 56 passed / 5 skipped,pnpm test:types11 passed,pnpm buildpass,pnpm publintall good. Mutation check: breaking the fixture's shrink expectation failsprop-failure.test.ts.Unblocks ScriptedAlchemy/agent-bundle#832 (Effect rc.117 re-pin).