fix(ci): copy exported test reports into evidence - #348
Merged
Merged
Conversation
c8fb90c (#345) made worker evidence count-only, so a red lane no longer names its failing tests anywhere: the check run and record carry JUnit counts and the exported XML stays in the sandbox temp dir. Copy the exported reports into evidence/pr-N-merge beside the count summary; the record and check bodies still carry only counts.
🦋 Changeset detectedLatest commit: e779145 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since #345 (c8fb90c), worker evidence is count-only. The check run, the record and the evidence JSON carry JUnit counts. The exported nextest XML stays in the sandbox's
reports-*temp dir and never reaches thehauler-ci-linux-<lane>artifact. As a result, a red hosted lane on tracedecay does not name its failing tests anywhere: not in the check text, the job log or the artifact.This PR restores the report files and leaves the record shape unchanged:
manager.mjspasses the exported reports dir topersistSnapshotas a third argument.main.mjscopies that dir toevidence/pr-N-<merge>/, next topr-N-<merge>.json.Test plan
node --test tests/github-action/*.test.mjs: 66 pass, 1 skip, including the new test "exported reports reach evidence persistence but not the record".pnpm buildregenerated the artifact, thenpnpm check:artifactpassed.pnpm typecheckpassed.