Skip to content

Derive dashboard payloads from generated route types - #165

Merged
ScriptedAlchemy merged 5 commits into
masterfrom
fix/153-generated-dashboard-types
Sep 7, 2026
Merged

ScriptedAlchemy merged 5 commits into
masterfrom
fix/153-generated-dashboard-types

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 7, 2026 •

Copy link
Copy Markdown
Owner

Closes #153.

Summary

  • derive dashboard status, request, metrics, savings, system, and kache payload types from AppRouteResult
  • delete optional-unknown protocol copies and manual payload reconstruction
  • validate only the untrusted opening host notification
  • add compile-time route equality assertions and production-profile browser tests

Verification

  • pnpm run check — passed (89 unit files / 1077 tests; 10 route files / 42 tests)
  • pnpm test:browser — passed (2/2)

Deslop

Deslop: GPT-5.6 Sol, 2 edits (removed temporary browser diagnostics and excluded the dedicated browser pool from the Node pool).

Final local gate

  • pnpm install --frozen-lockfile && pnpm run check on f981651 — passed against current master
  • validation/build/typecheck/diagnostics — passed
  • Node pool — 89 files, 1077 tests (1075 passed, 2 skipped)
  • route pool — 10 files, 42 tests; includes packed install/lifecycle regression
  • browser App pool — 1 file, 2 tests

Self-review

Reviewer: Claude Fable 5.1 Thinking High (review).

First pass findings and disposition:

  1. Browser pool absent from pnpm check — fixed; gate and AGENTS now include it.
  2. Branch/lock behind fix(deps): support Codex opaque-origin dashboard clients #164 — fixed; current master through Update dependency @types/react-dom to v19.2.7 #162/Update actions/checkout action to v6.1.0 #163 is merged and frozen-lock gated.
  3. Unused @rstest/playwright — removed.
  4. Kache optional-unknown reconstruction — deleted; pressure now derives from AppRouteResult.
  5. Opening rejection masked poll errors — fixed by preferring the actionable poll error.

Second pass: no remaining concrete merge risks.

@changeset-bot

changeset-bot Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: f981651

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cargo-hauler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-07T07:21:09.181998Z 477c727 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ScriptedAlchemy
ScriptedAlchemy merged commit 5765610 into master Sep 7, 2026
1 of 2 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/153-generated-dashboard-types branch September 7, 2026 07:36
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[P2] Preserve generated App route result types instead of rebuilding dashboard protocol shapes from unknown

1 participant