refactor(dev)!: remove the development runtime App-asset path - #856
Conversation
🦋 Changeset detectedLatest commit: 73d262f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73d262fb7f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| liveReload: false, | ||
| }, | ||
| } : {}), | ||
| ...(development ? {} : { app: { |
There was a problem hiding this comment.
When users consult the public example catalog, both website/docs/en/examples/index.mdx:25 and website/docs/zh/examples/index.mdx:23 still claim that the development session compiles App output and uses an HMR topology, while this conditional now excludes the app environment from development builds. The linked topology document also still describes an HMR lane and a generation-bound MCP App bridge. Update both locales and the topology prose so they describe App compilation as production-only and do not promise the removed runtime App path.
AGENTS.md reference: AGENTS.md:L89-L95
Useful? React with 👍 / 👎.
1 participant
Deletes the remaining Playground-era App-asset path from the dev runtime provider contract:
DevRuntimeSession.readAssetand/api/runtime/assets, the prepared-runtimeappsinput andDevRuntimePreparedMcpApp,DevRuntimeAssetRequest,DevRuntimeStatus.hmrReady, themcp-appruntime surface kind, themcp-protocol/resource-selection/sandbox/csp/app-bridgephases, and the launch/credential fields onDevRuntimePreparedMcpServer(now{ id, name, targets }). The Workbench runtime client and examples/rsc-agent-runtime are migrated: the example's dev session now compiles onlyrscandwidget; theappenvironment is production-build only.Checks:
pnpm test: build, unit, route-unit, projection passed. The integration pool had 4 failures (public-api x2, generated-route-server x2) becausepackages/agent-bundle/dist/index.d.tsdisappeared during the run. After a freshpnpm build, both files pass.pnpm examples:check: passed (after fixing a README wording and one stale example assertion).