refactor(routes): delete remaining legacy route shapes - #840
Conversation
Require CompiledAgentRoute.resultSchemaState, reject bare {} App/resource
contract fixtures, and drop AB4840 before/preflight export rejection.
🦋 Changeset detectedLatest commit: 04f6ff4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58bd18441d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
commit: |
Summary
Delete three remaining legacy route shapes that had to wait for #810.
Removal matrix
CompiledAgentRoute.resultSchemaStatebuild/entries.ts, Workbench route manifest schema{}App/resource fixtures inagent-bundle/testtests/support/contract-matrix-fixtures.ts, README{}acceptance; resource/app fixtures now require{ kind: 'resource' }AB4840forbefore/preflightevent exportstests/function-authoring.test.tsrejection-only case deletedAB4840keeps its other triggers.beforeandpreflightare now ordinary unused exports.Verification
On
81d240df07, rebased ontoorigin/mainafter #810 merged (18a913e9d8):pnpm build: passpnpm typecheck: passpnpm lint: passpnpm test:unit: pass (309 files, 4,480 tests)pnpm test:integration:run: pass (whole pool, 104 files, 1,187 tests)pnpm docs:site:build: pass (language parity OK, diagnostics coverage OK, 0 broken links)Review
Independent review (GPT-5.6, change-risk pass): no material findings. It checked the producers of
resultSchemaState, artifact bytes and digests (AB6039 evidence unaffected), the strict Workbench schema, auto-covered App fixtures, and ignoredbefore/preflightexports.Follow-up
Codex P1 (website docs for the fixture
kindrequirement) fixed in #850 inguide/development/testing.mdx(en, zh).