Skip to content

refactor(routes): delete remaining legacy route shapes - #840

Merged
ScriptedAlchemy merged 3 commits into
mainfrom
legacy/routes2
Sep 25, 2026
Merged

ScriptedAlchemy merged 3 commits into
mainfrom
legacy/routes2

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Sep 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

Delete three remaining legacy route shapes that had to wait for #810.

Removal matrix

Removed Callers migrated Deleted surface
Optional CompiledAgentRoute.resultSchemaState hand-built route literals in 13 test files, rendered-script routes in build/entries.ts, Workbench route manifest schema "legacy or manually assembled graphs" optionality and two conditional spreads
Bare {} App/resource fixtures in agent-bundle/test tests/support/contract-matrix-fixtures.ts, README legacy {} acceptance; resource/app fixtures now require { kind: 'resource' }
AB4840 for before/preflight event exports tests/function-authoring.test.ts rejection-only case deleted the removed-export guard; the en/zh "Migrating existing events" sections

AB4840 keeps its other triggers. before and preflight are now ordinary unused exports.

Verification

On 81d240df07, rebased onto origin/main after #810 merged (18a913e9d8):

  • pnpm build: pass
  • pnpm typecheck: pass
  • pnpm lint: pass
  • pnpm test:unit: pass (309 files, 4,480 tests)
  • pnpm test:integration:run: pass (whole pool, 104 files, 1,187 tests)
  • pnpm docs:site:build: pass (language parity OK, diagnostics coverage OK, 0 broken links)

Review

Independent review (GPT-5.6, change-risk pass): no material findings. It checked the producers of resultSchemaState, artifact bytes and digests (AB6039 evidence unaffected), the strict Workbench schema, auto-covered App fixtures, and ignored before/preflight exports.

Follow-up

Codex P1 (website docs for the fixture kind requirement) fixed in #850 in guide/development/testing.mdx (en, zh).

Require CompiledAgentRoute.resultSchemaState, reject bare {} App/resource
contract fixtures, and drop AB4840 before/preflight export rejection.
@changeset-bot

changeset-bot Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 04f6ff4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
agent-bundle Minor
create-agent-bundle Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-25T02:08:30.005641Z 58bd184 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 58bd18441d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/agent-bundle/README.md
@pkg-pr-new

pkg-pr-new Bot commented Sep 25, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@840
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@840
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/rsc-markdown-stream@840
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@840

commit: 81d240d

@ScriptedAlchemy
ScriptedAlchemy merged commit c42b93d into main Sep 25, 2026
3 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 25, 2026
@ScriptedAlchemy
ScriptedAlchemy deleted the legacy/routes2 branch September 25, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant