refactor(consumers): remove legacy Agent Bundle APIs - #808
Conversation
🦋 Changeset detectedLatest commit: e87ac03 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a438076abd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "name": "@agent-bundle-example/skills-starter", | |||
| "version": "1.0.0", | |||
There was a problem hiding this comment.
When packed-small-plugin.test.ts copies skills-starter, it replaces this manifest with { private, type } (lines 119–129), so after removing plugin.version the copied projects have no release identity and agent-bundle build fails with AB4013. Update those synthetic manifests to retain a semantic version in this change; otherwise the required packed-release gate remains red.
AGENTS.md reference: AGENTS.md:L32-L36
Useful? React with 👍 / 👎.
commit: |
…ge.json The example now declares its version in package.json, so the synthetic packed consumers need a semantic version to clear AB4013 and the examples contract asserts the resolved 1.0.0 label instead of the dev fallback.
1 participant
Summary
plugin.versiondeclarations to canonicalpackage.json.versionMcp.*/lowerMcpResultto Agent Documents anddocumentToCallToolResult, deleting the dead raw-render helper and legacy lowerer tests@types/react19.3.0, and@types/node26.5.1 while retaining the required Zod 4.5.4 peer floorFramework worker handoff
Mcpelements,lowerMcpResult, and exportedNativePostToolUseOutput; the sibling framework cleanup can delete those APIs without retaining an example compatibility path.examples/**from/fast/tmp/ab-legacy; this PR owns the consumer side.packages/agent-bundle/tests/packed-small-plugin.test.tscopiesexamples/skills-starterand replaces its canonicalpackage.json; withplugin.versiongone the synthetic consumers hitAB4013, so this PR gives both synthetic manifestsversion: '1.0.0'(same shape as the amp fixture).examples-contract.test.tsnow asserts the resolved1.0.0identity for Skills Starter instead of the development fallback. No framework-side follow-up remains for these two tests.Verification
pnpm build— passpnpm typecheck— passpnpm lint— passpnpm test:unit— passpnpm examples:check— passpnpm docs:site:build— pass, language parity cleanpnpm test:packed packages/agent-bundle/tests/packed-small-plugin.test.ts— pass after the fixture version fix (CI run 35077250965 hadRelease gatesandintegration-1red on exactly these two tests)AGENT_BUNDLE_*_PREBUILT=1 rstest --config rstest.integration.config.ts packages/agent-bundle/tests/examples-contract.test.ts— 5/5 passNo Workbench or MCP App UI behavior changed, so no new browser capture was required; existing RSC transport and invocation suites prove the populated text/image/structured output after projection.
Review
Independent
change-risk-reviewer(Sol) on head48c4e75: one blocking finding —packed-small-plugin.test.tsoverwrote the copiedskills-startermanifest without aversion, so withplugin.versionremoved the packed pool (test:packed, run by the PRRelease gatesjob viacheck:release:ci) failedAB4013. Fixed ine87ac03together with the siblingexamples-contract.test.tsassertion that still expected the development-fallback label. Everything else clean: the RSC example imports only the public@agent-bundle/runtimeroot (AgentDocument,documentToCallToolResult); text/image/structured output and document limits remain covered bydev-invocation.integration.test.tsandmcp-transports.integration.test.ts; docs already describeplugin.versionas deprecated and do not pin template versions; changeset names onlycreate-agent-bundle(patch).