Skip to content

fix(test): compare invocation replay with retained suffix - #765

Merged
ScriptedAlchemy merged 1 commit into
mainfrom
fix/invocation-replay-retained-suffix
Sep 8, 2026
Merged

ScriptedAlchemy merged 1 commit into
mainfrom
fix/invocation-replay-retained-suffix

Conversation

@ScriptedAlchemy

Copy link
Copy Markdown
Owner

Summary

  • compare the cancellation envelope with the retained suffix of an active reconnect stream
  • document why earlier replay events may legitimately precede that suffix
  • keep production behavior unchanged; no package changeset is needed for this test-only fix

Verification

  • pnpm build
  • pnpm typecheck
  • pnpm lint
  • pnpm test:unit (4,503 passed, 6 skipped)
  • affected integration test: 5 repeated normal runs
  • forced-race timing: failed 216 vs 167 before the assertion fix, passed after it

@changeset-bot

changeset-bot Bot commented Sep 8, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c594f28

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T05:51:31.755530Z c594f28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@pkg-pr-new

pkg-pr-new Bot commented Sep 8, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle@765
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/create-agent-bundle@765
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/rsc-markdown-stream@765
npm i https://pkg.pr.new/ScriptedAlchemy/agent-bundle/@agent-bundle/runtime@765

commit: c594f28

@ScriptedAlchemy
ScriptedAlchemy merged commit 945f94a into main Sep 8, 2026
16 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the fix/invocation-replay-retained-suffix branch September 8, 2026 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant