fix: check dependencies and devDependencies for @screenly/edge-apps#13
Open
nicomiguelino wants to merge 1 commit into
Open
fix: check dependencies and devDependencies for @screenly/edge-apps#13nicomiguelino wants to merge 1 commit into
nicomiguelino wants to merge 1 commit into
Conversation
Only devDependencies was checked, so Edge Apps that declare @screenly/edge-apps under dependencies would skip the build step. Fixes #12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes build-step detection in the initialize and update composite actions so TypeScript Edge Apps are built when @screenly/edge-apps is declared in either dependencies or devDependencies (resolving Issue #12).
Changes:
- Update the jq lookup to check a merged
dependencies+devDependenciesmap for@screenly/edge-apps. - Apply the same detection logic consistently in both
initializeandupdateactions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| initialize/action.yml | Detects @screenly/edge-apps in both dependencies and devDependencies to decide whether to run Bun install/build. |
| update/action.yml | Same merged-dependency detection to avoid skipping the build step when @screenly/edge-apps is not in devDependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializeandupdateactions only checkeddevDependenciesfor@screenly/edge-appswhen deciding whether to run the Bun build step, so Edge Apps that declare it underdependencieswould skip building entirely.dependenciesanddevDependenciesvia a merged jq lookup.Fixes #12