Correct the deploy docs and drop the remaining em dashes - #20
Open
vpetersson-bot wants to merge 1 commit into
Open
Correct the deploy docs and drop the remaining em dashes#20vpetersson-bot wants to merge 1 commit into
vpetersson-bot wants to merge 1 commit into
Conversation
Two doc/copy cleanups, no behaviour change. README.md already described the tag-driven deploy correctly (Screenly-Labs#18), but CLAUDE.md still said "Pushing to master runs deploy-pages.yml" and the workflow's own header comment still said it publishes "on every push to master". Neither is true: the trigger is a CalVer tag (or a manual workflow_dispatch). Both now match the workflow, and README's CalVer example is spelled YYYY.M.PATCH to match the tags actually in use. Also removes the remaining em dashes (55 across CLAUDE.md, README.md, main.css, build.ts, dev-server.ts, src/clocks.ts, src/main.ts and sync-fonts.ts), rewriting each to a colon, semicolon, comma or parenthetical as the sentence needs rather than swapping the character blindly. In the README parameter table the em dash was doing duty as the "no default" value, so it now reads "none". The manifest and meta description were already done in Screenly-Labs#19. lint, typecheck, test (35 pass) and build all clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19, which fixed only the manifest and meta description because those were the strings leaking onto signage-apps.com. This closes out the rest. No behaviour change.
Two stale deploy claims
README.mdalready got this right in #18, but two spots were missed:CLAUDE.md: "Pushing tomasterrunsdeploy-pages.yml, which re-runs those checks and publishes./distto GitHub Pages.".github/workflows/deploy-pages.yml, its own header comment: "Builds the static site and publishes ./dist to GitHub Pages on every push to master."Neither is true. The trigger is a CalVer tag push (
[0-9][0-9][0-9][0-9].*) or a manualworkflow_dispatch;masteralone ships nothing. Confirmed this release: merging #19 triggered no deploy, and only pushing2026.8.0published it. Both now match the workflow.While there, README's CalVer example said
YYYY.Nbut gave2026.8.0as the example; it now readsYYYY.M.PATCH, matching the tags actually in use.Remaining em dashes
55 of them, across
CLAUDE.md,README.md,assets/styles/main.css,build.ts,dev-server.ts,src/clocks.ts,src/main.tsandsync-fonts.ts.Each was rewritten to whatever the sentence actually wanted, a colon, semicolon, comma or parenthetical, rather than swapping the character blindly:
the accent is PER CARD — every city glows→…PER CARD: every city glowscan't belong to one time of day — many zones share it — so the backdrop→…one time of day (many zones share it), so the backdropa balanced block — 4 cities → 2x2, 7 → 4+3 — instead of→a balanced block (4 cities → 2x2, 7 → 4+3) instead ofdrop WHOLE zones — never a mid-name slice→drop WHOLE zones, never a mid-name sliceOne special case: in the README parameter table the em dash was standing in as the Default column value, so it now reads
nonerather than being turned into punctuation.Verification
bun run lint,bun run typecheck,bun test(35 pass) andbun run buildall clean. Zero em or en dashes left in any tracked file. Comment reflowing keepsmain.csswithin its existing wrap width.