Repository navigation
Lab runs: end every step with a result line, so quiet commands visibly finish - #4
Merged
Merged
Conversation
…y finish Suggestion from the first real use of the scimigo.com lab panel. After "$ python -m pip install --quiet ..." there was no way to tell whether pip was still running or had finished; a quiet command prints nothing either way. Every step now ends with a line of its own: [done · 2.1 s] [exit 3 · 0.4 s] [stopped · 5.0 s] [timed out · 1.0 s] It starts a new line even after output without a trailing newline (Run.append_line). The watchdog's separate "[runtime] timed out" line is gone, since the step's line now says it. Empty appends are ignored: the decoder's final flush added one, which hid whether the output ended a line. Tests: result lines for success, a failing step, stop and timeout, and a result line after output without a newline. 172 passed; ruff, format and mypy clean. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion from the first real use of the scimigo.com lab panel. After
$ python -m pip install --quiet …, there was no way to tell whether pip was still running or had finished, because a quiet command prints nothing either way.Every step now ends with a line of its own, on a new line even if the command's output didn't end with one:
The possible endings are
[done · N s],[exit C · N s],[stopped · N s]and[timed out · N s]. The watchdog's separate[runtime] timed outline is gone, since the step's line now says it. Empty appends are ignored; the decoder's final flush added one, which hid whether the output ended a line.Tests cover a result line for success, a failing step, stop and timeout, and a result line after output without a trailing newline. 172 passed; ruff, format and mypy clean.
🤖 Generated with Claude Code