Canonicalize remaining plain @testset units to @safetestset#461
Merged
ChrisRackauckas merged 1 commit intoJun 15, 2026
Merged
Conversation
Convert the independent test units in test/runtests.jl that were still plain `@testset "X" begin include(...) end` into `@safetestset` so each runs in its own module (isolation + world-age safety), matching the already-canonical units in this suite. Converted: GPU Kernelized Non Stiff ODE Regression, GPU Kernelized Stiff ODE Regression, Lower level API, and the four nested units inside the "Callbacks" group (Non Stiff/Stiff ODE ContinuousCallback, SDE Regression, SDE Convergence). The included files are already self-contained (own `using` lines + shared utils.jl include), so no file edits were needed; SafeTestsets injects `using Test` into each module so the bare `@test` calls resolve. Left "Distributed Multi-GPU" as a plain `@testset` (distributed addprocs/@Everywhere does not play nicely with modules, as noted in the file). Kept the "Callbacks" outer grouping `@testset` as a wrapper and the GROUP-dispatch ladder unchanged. SafeTestsets is already a test dep. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the independent test units in
test/runtests.jlthat were still plain@testset "X" begin include(...) endinto@safetestset, so each runs in its own module (test isolation + world-age safety), matching the units in this suite that are already@safetestset.Converted:
GPU Kernelized Non Stiff ODE RegressionGPU Kernelized Stiff ODE RegressionLower level APICallbacksgroup:Non Stiff ODE ContinuousCallback,Stiff ODE ContinuousCallback,SDE Regression,SDE Convergence.Left unchanged:
Distributed Multi-GPUstays a plain@testset— distributedaddprocs/@everywheredoes not play nicely with modules (as the file comment notes).Callbacksgrouping@testsetis kept as a wrapper; nested units inside it are now@safetestset.The included files are already self-contained (own
usinglines + sharedutils.jlinclude), and SafeTestsets injectsusing Testinto each module so the bare@testcalls resolve.SafeTestsetsis already a test dependency, so noProject.tomlchange was needed.Verification: static —
Meta.parseallofruntests.jlparses cleanly and Runic formatting passes. This is a GPU suite that requires GPU hardware, so it was not run locally; CI will verify.This PR should be ignored until reviewed by @ChrisRackauckas.
🤖 Generated with Claude Code