Canonical CI: grouped-tests.yml + root test/test_groups.toml#311
Merged
ChrisRackauckas merged 1 commit intoJun 8, 2026
Merged
Conversation
Convert the root Tests.yml test workflow to the canonical thin caller of SciML/.github/.github/workflows/grouped-tests.yml@v1, moving the group x version x os matrix into a root test/test_groups.toml. The matrix is reproduced exactly (27/27): groups Core, QA, NoPre, each on versions ["1","lts","pre"] and OSes ["ubuntu-latest","macos-latest","windows-latest"]. runtests.jl already dispatches on GROUP (Core/QA/NoPre), so no runtests.jl change is needed. No with: inputs are required since the old caller used all defaults (GROUP env var, check-bounds yes, coverage on, src,ext directories). on: triggers and concurrency: are preserved verbatim; filename and name: are unchanged to keep branch-protection status checks intact. Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com> Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the root
Tests.ymltest workflow into the canonical thin caller ofSciML/.github/.github/workflows/grouped-tests.yml@v1, with the test matrix declared once in a roottest/test_groups.toml.The
jobs.testsblock is now simply:No
with:inputs are needed: the old caller used all defaults (GROUPenv var,check-bounds: yes, coverage on,coverage-directories: src,ext, no apt packages).runtests.jlalready dispatches onGROUP(Core / QA / NoPre), so it is unchanged.The
on:triggers andconcurrency:block are preserved verbatim, and the filename (Tests.yml) andname: "Tests"are unchanged so existing branch-protection status checks keep matching.Matrix declared in
test/test_groups.tomlMatrix match: 27/27 exact
Verified with
scripts/compute_affected_sublibraries.jl . --root-matrix(SciML/.github@v1). The emitted(group, version, runner)set is exactly the oldTests.ymlcartesian product —{Core, QA, NoPre} x {1, lts, pre} x {ubuntu-latest, macos-latest, windows-latest}= 27 cells, no missing, no extra. TOML and YAML both parse cleanly.QA findings
None. Category A repo —
runtests.jlalready hasCore/QA/NoPreGROUP dispatch and aQAgroup running Aqua; no runtests.jl change and no source-bug exclusions were introduced.Project.tomlmetadata already conforms (julia floor1.10LTS,[compat]entries present,[extras]/[targets].testaligned), so no benign-metadata fixes were required.Ignore until reviewed by @ChrisRackauckas.