Add ability to read GZip-Compressed log files#34
Open
jfontsaballs wants to merge 1 commit intoScarfsail:mainfrom
Open
Add ability to read GZip-Compressed log files#34jfontsaballs wants to merge 1 commit intoScarfsail:mainfrom
jfontsaballs wants to merge 1 commit intoScarfsail:mainfrom
Conversation
Author
|
Magic number for recognizing a GZip file found in https://stackoverflow.com/questions/6059302/how-to-check-if-a-file-is-gzip-compressed |
Scarfsail
requested changes
Feb 16, 2024
Owner
Scarfsail
left a comment
Scarfsail
left a comment
There was a problem hiding this comment.
Please look at my comment regardning .gz extension detections. Otherwise looks good, thanks for the contribution!
| { | ||
| using (TextReader sr = new StreamReader(fs, true)) | ||
| var isGzip = false; | ||
| if (LogFileName.Contains(".gz")) |
Owner
There was a problem hiding this comment.
Wouldn't be better to use EndsWith instead of Contains? I assume that we are interested only in files ending by .gz.
And I would also add StringComparer.OrdinalIgnoreCase option.
| { | ||
| using (TextReader sr = new StreamReader(fs)) | ||
| var isGzip = false; | ||
| if (fileName.Contains(".gz")) |
Owner
There was a problem hiding this comment.
The same comment as above. Otherwise no comments, thanks for the PR! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#33