Conversation
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Collaborator
|
I think this looks good, thanks @justinc1! Approved. |
anazobec
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR add optional wait on VM to get IP address. This is enabled by setting
wait_for_guest_net_timeoutinhypercore_vm_power_stateresource. Unit forwait_for_guest_net_timeoutare seconds.Partially fixes #96 - the tests are missing. I tested code manually, using Alma 10 cloud image.
PR also fixes nice ACPI VM shutdown bug. The rest API does return a taskTag if we start VM. But it does not return a taskTag for a nice VM shutdown (
"actionType":"SHUTDOWN"). This resulted in provider failure - provider noticed VM is still running after"actionType":"SHUTDOWN", and thought shutdown request was somehow ignored. In fact provider just need to wait a bit. Wait time is limited to 300 sec.CI failure in TestAccHypercoreVMsDatasource_stopped - the test VM has more disks/nics than our test expects. I think because the same VM name is used in ansible collection tests.