Feature/auth improvements#41
Conversation
…n system with modular architecture
…n system with modular architecture
This PR is being reviewed by Cursor BugbotDetailsYou are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle. To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
Bug: Refresh Token Method Throws Errors Instead of BooleansBreaking change in refreshToken$() method contract. The method signature declares it returns Observable but now throws errors instead of returning false on failure. This breaks existing code that expects boolean returns, specifically the AuthGuard (lines 14-24 in auth.guard.ts) and the 401 error handler in the auth interceptor (lines 46-56 in auth.interceptor.ts) which use conditional logic like "if (success)" expecting boolean values. |
Bug: Proactive Token Refresh Error HandlingUnhandled error in proactive token refresh. The code calls authService.refreshToken$().subscribe() with no error handling, but refreshToken$() now throws errors instead of returning false. This will cause unhandled promise rejections when token refresh fails during proactive refresh, potentially crashing the application. |
Bug: Token Refresh Fails to Update User DataMissing user data fetch after token refresh. The refreshToken$() method no longer calls userStore.fetchUser$() after successfully refreshing the token, which could lead to inconsistent state where the application has a valid access token but no user data. This may cause authorization issues or missing user context in the UI. |
…n system with modular architecture
…ving angular-cli-ghpages
No description provided.