Skip to content

Feature/auth improvements#41

Merged
SatanLittleHelper merged 6 commits into
mainfrom
feature/auth-improvements
Oct 23, 2025
Merged

Feature/auth improvements#41
SatanLittleHelper merged 6 commits into
mainfrom
feature/auth-improvements

Conversation

@SatanLittleHelper

Copy link
Copy Markdown
Owner

No description provided.

@cursor

cursor Bot commented Oct 23, 2025

Copy link
Copy Markdown

This PR is being reviewed by Cursor Bugbot

Details

You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

@cursor

cursor Bot commented Oct 23, 2025

Copy link
Copy Markdown

Bug: Refresh Token Method Throws Errors Instead of Booleans

Breaking change in refreshToken$() method contract. The method signature declares it returns Observable but now throws errors instead of returning false on failure. This breaks existing code that expects boolean returns, specifically the AuthGuard (lines 14-24 in auth.guard.ts) and the 401 error handler in the auth interceptor (lines 46-56 in auth.interceptor.ts) which use conditional logic like "if (success)" expecting boolean values.

Fix in Cursor Fix in Web

@cursor

cursor Bot commented Oct 23, 2025

Copy link
Copy Markdown

Bug: Proactive Token Refresh Error Handling

Unhandled error in proactive token refresh. The code calls authService.refreshToken$().subscribe() with no error handling, but refreshToken$() now throws errors instead of returning false. This will cause unhandled promise rejections when token refresh fails during proactive refresh, potentially crashing the application.

Fix in Cursor Fix in Web

@cursor

cursor Bot commented Oct 23, 2025

Copy link
Copy Markdown

Bug: Token Refresh Fails to Update User Data

Missing user data fetch after token refresh. The refreshToken$() method no longer calls userStore.fetchUser$() after successfully refreshing the token, which could lead to inconsistent state where the application has a valid access token but no user data. This may cause authorization issues or missing user context in the UI.

Fix in Cursor Fix in Web

@SatanLittleHelper SatanLittleHelper merged commit d8d79de into main Oct 23, 2025
1 check passed
@SatanLittleHelper SatanLittleHelper deleted the feature/auth-improvements branch October 23, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant