Skip to content

Корректная очистка вершинных каналов в CollisionMeshBuilder - #178

Closed
SashaRX wants to merge 1 commit into
mainfrom
codex/propose-fix-for-ineffective-collision-channel-stripping
Closed

Корректная очистка вершинных каналов в CollisionMeshBuilder#178
SashaRX wants to merge 1 commit into
mainfrom
codex/propose-fix-for-ineffective-collision-channel-stripping

Conversation

@SashaRX

@SashaRX SashaRX commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Исправить неэффективную очистку каналов вершины у сгенерированных collision-мешей: Mesh.Clear() по умолчанию сохранял декларацию вершинного layout и не удалял лишние атрибуты (нормали, тангенты, UV, цвета), хотя данные очищались.

Description

  • В Editor/CollisionMeshBuilder.cs заменено mesh.Clear(); на mesh.Clear(false);, чтобы удалить прежнюю разметку каналов и затем восстановить только позиции и треугольники; поведение по пересчёту границ и именованию сохранено.

Testing

  • Выполнены автоматизированные проверки: git diff --check прошёл успешно, статическая проверка наличия mesh.Clear(false); обнаружила ровно один вхождение, и коммит создан (Fix collision vertex channel stripping); запуск Unity EditMode-тестов невозможен в контейнере (Unity не установлен).

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a4d03a92-e91b-443d-9574-137175047009

📥 Commits

Reviewing files that changed from the base of the PR and between 21d382e and 86b00f2.

📒 Files selected for processing (1)
  • Editor/CollisionMeshBuilder.cs

Comment @coderabbitai help to get the list of available commands.

SashaRX commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

Фикс вошёл в консолидированную ветку claude/security-pr-analysis-fmpzf0 коммитом 543795e. Закрыт как superseded.


Generated by Claude Code

@SashaRX SashaRX closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant