Skip to content

Восстановление preview-мешей перед обновлением контекста при undo/redo - #176

Closed
SashaRX wants to merge 1 commit into
mainfrom
codex/fix-undo/redo-handler-to-restore-meshes
Closed

Восстановление preview-мешей перед обновлением контекста при undo/redo#176
SashaRX wants to merge 1 commit into
mainfrom
codex/fix-undo/redo-handler-to-restore-meshes

Conversation

@SashaRX

@SashaRX SashaRX commented Aug 6, 2026

Copy link
Copy Markdown
Owner

Motivation

  • Исправить баг, когда обработчик OnUndoRedo напрямую вызывал ctx.Refresh(...) пока в сцене стояли временные preview-меши, из‑за чего временные sharedMesh могли закешироваться как исходные и привести к утечке/порче ссылок на импортированный меш.

Description

  • В Editor/Framework/UvToolHub.cs перед вызовом ctx.Refresh(...) добавлены вызовы ApplyPreviewMode(UvCanvasView.PreviewMode.Off) и RestoreWorkingMeshes(), что отключает активные превью и восстанавливает/удаляет временные рабочие меши до перестроения MeshEntries.

Testing

  • Запущены автоматические проверки: git diff --check и статическая проверка порядка вызовов (подтверждающая, что ApplyPreviewModeRestoreWorkingMeshes выполняются до ctx.Refresh), обе проверки прошли; EditMode Unity-тесты не запускались в этой среде, так как бинарник Unity отсутствует.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 45 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0f09f12e-b539-4790-a34a-d942a3323469

📥 Commits

Reviewing files that changed from the base of the PR and between 21d382e and e10a57b.

📒 Files selected for processing (1)
  • Editor/Framework/UvToolHub.cs

Comment @coderabbitai help to get the list of available commands.

SashaRX commented Aug 6, 2026

Copy link
Copy Markdown
Owner Author

Фикс вошёл в консолидированную ветку claude/security-pr-analysis-fmpzf0 коммитом d0a6ba9. Закрыт как superseded.


Generated by Claude Code

@SashaRX SashaRX closed this Aug 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant