-
Notifications
You must be signed in to change notification settings - Fork 0
Add multi-case sweep, visual-defect metrics, and transfer diagnostics #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SashaRX
wants to merge
110
commits into
main
Choose a base branch
from
claude/fix-transfer-bugs-KYVQD
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
110 commits
Select commit
Hold shift + click to select a range
fb3233f
Add TransferDiag summary log to GroupedShellTransfer
claude 5340f67
Drop hint-matched dedup bypass for overlapping-UV0 case
claude 442f2bb
EXPERIMENTS.md: post-fix Carousel verification for hint-matched dedup…
claude 90a7940
Revert "EXPERIMENTS.md: post-fix Carousel verification for hint-match…
claude aaba5ff
Revert "Drop hint-matched dedup bypass for overlapping-UV0 case"
claude 9d38c27
Add visual-defect counters to TransferResult + sweep
claude 14145e2
Add multi-case sweep runner — one click, every model in TestSuiteAsset
claude 5a67304
Address Codex review on PR #118: 1×P1 + 4×P2
claude c7a2c85
Sweep: 2 new axes + provenance manifest + auto-archive
claude 411ca9a
Resolve PackageInfo and CompressionLevel namespace ambiguity in sweep
claude b4a0828
Add HierarchicalDiag — feasibility probe for inverse-hierarchical UV2…
claude 0457313
Add .meta for HierarchicalDiag.cs (fix CI meta-validation)
claude 26807fa
Address Codex review on PR #118: 1×P1 + 2×P2
claude 5f24797
HierDiag v2: shell-level matching + K-nearest face→shell pick
claude 80c6588
HierDiag v3: add perpendicular-offset criterion for promotion
claude e64739e
PR-2: HierarchicalRepack — builder for inverse-hierarchical atlas
claude 3f04541
PR-2.5: shell-level Overlay/Promote/Skip + vertex dedup
claude 888ed22
PR-2.5 hotfix: return rewritten tris from BuildCanonicalIndices
claude fb51c30
Address Codex review on PR #118: 1×P2 fix in HierarchicalRepack
claude d592c99
Address Codex review on PR #118: 1×P1 + 3×P2
claude f183cb7
PR-2.5: dry-run handles multi-select + prefab assets
claude a68ee55
PR-2.5 hotfix: drop stray closing brace after CollectSelectedLodGroups
claude 9bbc8e9
PR-2.5 hotfix: HashSet uses .Count, not .Length
claude 8ed3325
PR-2.5: drop K-nearest filter in ClassifyFineShell — full scan
claude 5cc70d2
PR-2.5 Step 1b: pick best overlay-eligible parent, not just best angle
claude 35c8d9b
PR-2.5 Step 2: loosen overlay thresholds for tilted/oversized fine sh…
claude 835388f
PR-2.7: Frostbite-style per-vertex projection classifier
claude 8211e92
Unified benchmark: one button runs every technique per case
claude 41e497b
Unified benchmark hotfix: WriteReport should be private, not internal
claude 5755de2
Unified benchmark hotfix: rename ExecBenchmark's `t` to `tech`
claude b97c46c
PR-2.7 Option B: merge adjacent base shells with close normals
claude fe966b4
Diagnostic PNGs: atlas layout + per-fine-LOD domain classification
claude 30baf9a
Diagnostic PNG hotfix: qualify Object.DestroyImmediate
claude 6328c26
Unified bench: legacy sweep + readable LOD PNGs
claude c8902bd
Unified bench: human-readable run-stamp folder name
claude ed8a029
Unified bench: technique subfolders + clean per-file names
claude 969fa60
Unified bench: NO writes to BenchmarkReports/ root, ever
claude 2ce45d9
PR-2.7 → per-shell majority vote, looser distance threshold
claude 9f0420a
Per-LOD diagnostic: isometric view + solid category palette
claude c94d8aa
PR-3 stage 1: proxy UV2 via xatlas auto-pack + visualization
claude c1eeaa8
PR-3 stage 1 fix: sym-split BEFORE xatlas auto-pack
claude f6d05d2
PR-3 stage 1: 3-way proxy UV2 comparison (clean / raw / auto-unwrap)
claude da4ab81
Build native libraries (auto) [skip ci]
github-actions[bot] 6b30bc3
Address Codex review on PR #118: 4×P2
claude 0773e46
PR-3 stage 1 hotfix: RepackOptions is a top-level struct, not nested
claude 35a68fd
PR-3 stage 1: ProxyMode toggle (Clean / Raw / Auto)
claude 91a93b0
PR-3 stage 2: Poisson sampling on active proxy + visualization
claude e97aa84
PR-3 stage 2 hotfix: dot positions must match UvPngWriter's UV range
claude b16742b
PR-3 stage 2: enrich ProxySample with normal / shell id / sample id
claude c8f20cb
PR-3 stage 3: project proxy samples onto each fine LOD + heatmap
claude c26c06b
Address Codex review on PR #118: 1×P1 + 2×P2
claude c77f1ea
PR-3 stage 2: skip rogue cross-chart tris during sampling
claude de95dc5
PR-3 stage 1: disable xatlas chart rotation in all 3 proxy variants
claude 33dddb7
PR-3 fix: drop the Y-flip on proxy sample dots
claude e52fcb3
PR-3 stage 4: per-shell affine fit (worldPos -> uv2)
claude 9772b3f
PR-3 stage 4: filter per-shell fit by dominant proxy chart
claude 00b6a80
PR-3 stage 5: final UV2 per fine LOD + spill / mixed handling + adapt…
claude 6fbe843
PR-3 stage 5: duplicate seam vertices so shells never share a UV slot
claude 7ee8f28
PR-3 stage 5: revert clamp / scale / promote -- spill is by design
claude 0031ae9
PR-3 stage 4 rework: group by proxy chart, not fine 3D shell
claude 6ed1567
PR-3 stage 5: per-face fallback to ONE proxy face (was per-vertex)
claude 4b86527
PR-3 stage 5: per-chart planar fallback (was per-face closest proxy)
claude 0e97a3c
PR-3 stage 5: per-vertex closest-proxy-face in chart (was planar fall…
claude 74d3b72
PR-3 stage 5: rip out affine fit, do the simple ortho-project
claude b2442d1
fix: restore WriteFinalUv2Pngs (got eaten by the stage 4 cleanup sed …
claude c0baeab
PR-3 stage 6: clone fine LOD meshes with the new uv2, apply via menu
claude f76b5c9
ci: add missing .meta for HierarchicalApply.cs
claude 60cc37a
PR-3 stage 5: drop the 'any sign' fallback -- strict normal-sign only
claude 7ecbbfb
hier stage 5: cage-style max-distance limit; bench: shorten PNG subfo…
claude 5fd767e
hier stage 5: per-vertex closest-point + UV-winding twin disambig + b…
claude 5edbced
hier stage 5: revert per-vertex MAX-of-3 to centroid ranking
claude afdf140
hier stage 5: Poisson sample vote + ray-cast fallback (centroid-close…
claude 8d219b3
hier stage 5: kill the ray-cast fallback -- Poisson vote only, sentin…
claude 5975e63
hier stage 5: dedup seam vertices by proxy CHART, not proxy face
claude 3fb4c01
hier stage 2: drop adaptive rogue-tri filter -- it ate big panel samples
claude b87ed73
docs: hierarchical cascade projection plan (stages A-F, test-per-stage)
claude 3bcfdfb
hier stage B: per-LOD classical xatlas unwrap (diagnostic only)
claude fc66410
docs: cascade plan v2 -- group-then-final-pack, dissolves locked-char…
claude c9948e6
hier: purge legacy PR-2 classifier + PR-3 single-proxy projector
claude 4f7ef2a
docs: cascade plan — mark stages A/B/purge done, expand Stage C as cu…
claude 431ceac
hier stage C: per-LOD 3D shell extract + seed groups from deepest LOD
claude d4c46d8
weld: skip cross-shell welds for instance-pair UV shells (mirror / N-…
claude 05753e1
weld: split meshopt GPU-dedup from UV-aware seam weld (per meshopt docs)
claude eb99cde
fix(weld): qualify UnityEngine.Object.Instantiate after 'using System…
claude a98acab
fix(pipeline): rewind working meshes to fbx at start of each run (ide…
claude cbefdb6
fix(symsplit): gate N-fold cut by UV self-overlap in primary Split path
claude 19dd113
fix(symsplit): switch N-fold gate to UV coverage ratio (was density f…
claude ebaaaec
fix(symsplit): combine vote-ratio + coverage gate, log unconditionally
claude 1b94229
hier stage D: cascade group shells deep→fine (membership only)
claude 2d42eba
hier stage D: opt-in matchFrac×minHits threshold sweep
claude 0685961
hier stage D: tiny-shell merge + experiments log
claude 37932c4
hier stage D sweep: suppress per-cell PNG noise by default
claude b00aa52
docs: record post-tiny-merge sweep results in EXPERIMENTS.md
claude 052a2c2
hier stage E (slice E1): pack lighting-domain canonical charts
claude f24e1d1
docs: record E1 benchmark results — packing works, curved-shell foldi…
claude be55239
hier stage E: stitch authored UV0 shells instead of planar projection
claude f02356a
hier stage E2: the actual cascade — project every LOD into its domain…
claude 869f609
docs: E2 benchmark confirms cascade — cross-LOD consistency verified
claude 49ee1e0
hier stage E: kill per-shell [0,1] distortion — real proportions, uni…
claude 81af569
hier stage E: PRESERVE shell UV0 + project it (no planar re-derivation)
claude 9c704ae
hier stage E: fix CS0136 — rename face-corner locals (fc clashed)
claude 9777ff9
docs: preserve-UV0 benchmark confirms — no folding, cross-LOD consistent
claude 2895cbc
hier stage E: robust placements — degenerate-axis LSQ fallback, never…
claude 4aa044b
hier stage E3: objective atlas metrics — overlap, density spread, cro…
claude 2614314
hier stage D sweep: append Stage E3 aggregates per cell
claude 6d34a8f
docs: EXPERIMENTS entry — Stage E3 metrics + E2 placement robustness
claude fd6da0e
docs: transfer pipeline audit — cross-cutting problems in both genera…
claude e8deec9
docs: UV transfer debug & test plan — fixture ladder + objective gates
claude 21172c8
chore: update file references and ignore patterns
SashaRX 455260c
refactor: standardize package identity and logging conventions
SashaRX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
8 changes: 0 additions & 8 deletions
8
.claude/skills/_archive/migration-and-refactor-planner.pre-overhaul.md
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
.claude/skills/_archive/unity-assetdatabase-tools.pre-overhaul.md
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
.claude/skills/_archive/unity-package-architect.pre-overhaul.md
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
.claude/skills/_archive/unity-package-reviewer.pre-overhaul.md
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
.claude/skills/_archive/unity-serialized-workflow.pre-overhaul.md
This file was deleted.
Oops, something went wrong.
8 changes: 0 additions & 8 deletions
8
.claude/skills/_archive/unity-undo-prefab-safety.pre-overhaul.md
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Security & Privacy | 🟠 Major | ⚡ Quick win
Information Disclosure (CWE-200): Exposure of Sensitive Information to an Unauthorized Actor
Reachability: Internal
P1: Не перечисляйте другие agent skills и конфигурационные каталоги.
Добавление этой проверки закрепляет доступ к
.claude/skills, а discovery-команда на Line 101 перечисляет и читаетSKILL.mdдругих skills. Ограничьте аудит явным allowlist-манифестом или переданными параметрами; не сканируйте.claude/,.codex/или.gemini/.🧰 Tools
🪛 SkillSpector (2.3.11)
[error] 101: [AS1] Agent Config Directory Access: Skill reads from agent configuration directories (.claude/, .codex/, .gemini/). These directories may contain API keys, personal settings, and other credentials that the skill has no legitimate need to access.
Remediation: Remove all code or instructions that access agent configuration directories (.claude/, .codex/, .gemini/). If configuration values are needed, pass them explicitly as parameters or environment variables — never read the agent's own config files.
(Agent Snooping (AS1))
[warning] 55: [AS3] Skill Enumeration: Skill enumerates or reads other installed skills. Access to other skills' SKILL.md files or the skills directory reveals prompt instructions, capabilities, and secrets that should be invisible to peer skills.
Remediation: Remove all code or instructions that list or read other skills' files or directories. Skills should operate independently; cross-skill access is a privilege escalation.
(Agent Snooping (AS3))
[warning] 101: [AS3] Skill Enumeration: Skill enumerates or reads other installed skills. Access to other skills' SKILL.md files or the skills directory reveals prompt instructions, capabilities, and secrets that should be invisible to peer skills.
Remediation: Remove all code or instructions that list or read other skills' files or directories. Skills should operate independently; cross-skill access is a privilege escalation.
(Agent Snooping (AS3))
🤖 Prompt for AI Agents
Source: Linters/SAST tools