fix: repair release-please pipeline configuration and publishing#12
Merged
Conversation
Add packages key to release-please-config.json so manifest mode can map commits to the root package. Reset manifest version to 0.2.0 to match the existing git tag. Chain publish job inside release-please.yml using release_created output instead of relying on GITHUB_TOKEN-created tags to trigger publish.yml. Set include-component-in-tag and include-v-in-tag to false for consistent bare numeric tag format (e.g. 0.3.0). Update README CI/CD docs and mark publish.yml as fallback.
Remove tracked phase4_benchmark.json and phase5_benchmark.json from the repository. Widen the gitignore glob from benchmark_*.json to *benchmark*.json so all benchmark output variants are ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packageskey torelease-please-config.json, mapping the root package (.) with explicit settings.release-please-manifest.jsonfrom0.3.0to0.2.0to match the existing0.2.0git tag, allowing release-please to correctly compute the next versionpublishjob insiderelease-please.ymlthat triggers onrelease_created, eliminating theGITHUB_TOKENlimitation where tags created by it cannot trigger downstream workflowsinclude-component-in-tag: falseandinclude-v-in-tag: falsefor bare numeric tags (e.g.0.3.0) matchingpublish.ymlexpectationspublish.ymlas a manual fallback workflow and update README CI/CD documentationRoot Causes Fixed
packagesto map commits to paths; without it, all commits were filtered out (Splitting 0 commits by path)0.3.0but only tag0.2.0exists, so release-please couldn't anchor to any releasepublish.ymlnever fireddataforge-v0.2.0style tags instead of bare0.2.0After Merge
Once this PR merges, the release-please workflow will run on
mainand should create a release PR proposing version0.3.0with a full changelog of all changes since tag0.2.0.