Skip to content

feat(minimize): harden DeltaDebugger mutation coverage and fix partitioning bug #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamuelIVX merged 2 commits into from
Oct 16, 2026
Merged

feat(minimize): harden DeltaDebugger mutation coverage and fix partitioning bug #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77320eb
test(minimize): harden DeltaDebugger mutation coverage and fix partit…
SamuelIVX Oct 15, 2026
ba22589
fix(minimize): widen partition arithmetic, document tests, and fix de…
SamuelIVX Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 11 additions & 14 deletions src/main/java/dev/samhb/interleave/minimize/DeltaDebugger.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,11 @@ public Trace minimize(Program program, Trace failingTrace, TraceOutcome expected
List<StepOutcome> outcomes = new ArrayList<>(failingTrace.outcomes());

int n = threadIds.size();
if (n <= 1) {
return Trace.of(threadIds, outcomes, expectedOutcome);
}

for (int m = 2; m <= n; m = m * 2) {
if (m > n) m = n;

int chunkSize = n / m;
if (chunkSize == 0) chunkSize = 1;

for (int i = 0; i < m && n - i * chunkSize > 0; i++) {
int start = i * chunkSize;
int end = Math.min(start + chunkSize, n);
for (int m = 2; m <= n; ) {
for (int i = 0; i < m; i++) {
int start = (int) ((long) i * n / m);
int end = (int) ((long) (i + 1) * n / m);

List<Integer> reducedThreadIds = new ArrayList<>();
List<StepOutcome> reducedOutcomes = new ArrayList<>();
Expand All @@ -68,6 +60,12 @@ public Trace minimize(Program program, Trace failingTrace, TraceOutcome expected
return minimize(program, reducedTrace, expectedOutcome, invariant);
}
}

int nextM = Math.min(m * 2, n);
if (nextM == m) {
break;
}
m = nextM;
}

return Trace.of(threadIds, outcomes, expectedOutcome);
Expand Down Expand Up @@ -96,11 +94,10 @@ public Trace minimize(Program program, Trace failingTrace, TraceOutcome expected
* @return true if the final configuration satisfies the selected outcome check;
* false for an illegal schedule or {@code INCOMPLETE}
*/
private boolean isStillFailing(Program program, Trace trace, TraceOutcome expectedOutcome, Invariant invariant) {
boolean isStillFailing(Program program, Trace trace, TraceOutcome expectedOutcome, Invariant invariant) {
try {
ExecutionDriver driver = new ExecutionDriver();
Configuration config = driver.run(program, new Schedule(trace.threadIds()));
if (config == null) return false;

return switch (expectedOutcome) {
case COMPLETED -> config.allTerminated();
Expand Down
Loading
Loading