Repository navigation
fix: prevent duplicate wallpaper listeners - #9
Merged
Merged
Conversation
Separate one-shot refresh from session-owned listening and bound daemon startup. Add isolated regression checks and CI. Co-authored-by: Codex <noreply@openai.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing (6)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Explicitly reject failed compositor queries while preserving event listening. Add a failed-query regression case. Co-authored-by: Codex <noreply@openai.com>
SamuelIVX
marked this pull request as ready for review
October 13, 2026 03:26
* fix: make rofi pickers handle selections correctly Preserve SSIDs and paths using indexed selections. Implement clipboard delete and confirmed clear, and keep cancellation side-effect free. Co-authored-by: Codex <noreply@openai.com> * fix: reserve clipboard deletion keys for picker actions Remove Delete from Rofi text editing before assigning the clipboard action. Add a regression check for conflicting bindings. Co-authored-by: Codex <noreply@openai.com> * fix: make workstation tuning conservative and verifiable (#11) Limit automatic tuning to backed-up file-watch configuration. Preserve higher limits, verify effective values, and restore on failure. Document optional system changes and rollback separately. Co-authored-by: Codex <noreply@openai.com> --------- Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Autostart and SUPER+A start permanent wallpaper listeners, so refreshes can accumulate duplicate listeners. Startup also assumes awww is ready.
Summary
Add a one-shot refresh mode and a per-session lock; validate dependencies, session socket, images, and bounded daemon readiness. Report compositor-query failures explicitly while keeping the listener alive. Preserve workspace mappings and visual settings. Add isolated shell regression checks and CI.
Tests
Local bash tests/run.sh and git diff --check passed. Duplicate-listener and one-shot regressions failed against the original script. CI passed regression tests and ShellCheck on the current head; local ShellCheck is unavailable. Live compositor verification blocked by sandbox socket permissions.
Risks and rollback
First of five stacked draft PRs. Live configuration has not been changed. Revert this PR to restore the previous listener behavior. Keep draft until CI and host-session checks are complete.
Co-authored-by: Codex noreply@openai.com