Log invalid skills at debug level instead of writing to stderr - #1183
Merged
SamSaffron merged 1 commit intoSep 27, 2026
Merged
Conversation
Skill discovery printed a warning to stderr for every invalid skill on each registry scan. Ecosystem skill directories commonly contain skills that fail validation (for example legacy underscore names), and the raw stderr writes bypass the terminal UI and corrupt the display. Route the diagnostic through slog at debug level so it stays available without interfering with rendering. Add a regression test that scans an invalid skill and asserts nothing is written to stderr. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
Author
|
Example of warning message bleeding in the TUI: 
|
Owner
|
looks good, seems like there is one more pokemon to catch ... will catch them all folowing this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skill discovery wrote
warning: skipping invalid skill ...directly to stderr for every invalid skill on each registry scan. Ecosystem skill directories (Claude, Codex, etc.) commonly contain skills that fail validation, such as legacy underscore names likemd_solve_tickets. Because the registry is scanned repeatedly, those raw stderr writes bypass the TUI and corrupt the terminal display.This change:
logSkippedInvalidSkillhelper that logs throughslog.Debugwith the skill path and error.fmt.Fprintf(os.Stderr, ...)calls inHasAnySkillandscanDirWithFingerprintwith the helper.Test plan
TestRegistryInvalidSkillDoesNotWriteToStderrcreates an invalid skill, scans it viaHasAnySkillandList, and asserts it is skipped with nothing written to stderr. This test fails before the fix.go test ./internal/skills/passes (81 tests).go vet ./internal/skills/,make build, andmake complexitypass.🤖 Generated with Claude Code