feat(benchmarks): make busybox image configurable via BUSYBOX_IMAGE env var#98
Open
k-wall wants to merge 3 commits into
Open
feat(benchmarks): make busybox image configurable via BUSYBOX_IMAGE env var#98k-wall wants to merge 3 commits into
k-wall wants to merge 3 commits into
Conversation
When kafka.metrics.enabled=true in the Helm values (e.g. via cluster-overrides.yaml), Strimzi deploys a JMX Prometheus exporter sidecar on each Kafka broker pod. Metrics are exposed on port 9404. Adds poll-kafka-metrics.sh, which port-forwards to a broker pod and polls /metrics every METRICS_INTERVAL seconds, writing timestamped snapshots to kafka-metrics.txt in the probe output directory. If the endpoint is not available (metrics disabled), the script exits cleanly after 15 s so the benchmark is not disrupted. Wires the kafka metrics poller into run-benchmark.sh alongside the existing proxy metrics poller — started before the benchmark and stopped after it completes. The captured metrics enable direct observation of Kafka-side bottlenecks during connection sweeps: - kafka_server_requesthandlerpool_requesthandleravagidle (near 0 = I/O thread pool saturated) - kafka_network_socketserver_networkprocessoravagidle (network threads) - kafka_server_brokertopicmetrics_bytesin/outpersec_rate (throughput) - kafka_server_replicamanager_isrshrinks_rate (replication lag) - kafka_network_requestmetrics_totaltimems_produce (produce latency) Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: Sam Barker <sam@quadrocket.co.uk>
…nv var The result collection pods use busybox to mount PVCs and copy files. Previously the image was hardcoded to docker.io busybox:1.37.0, which can hit Docker Hub rate limits in CI/testing environments. Added BUSYBOX_IMAGE environment variable to both scripts: - run-benchmark.sh: for OMB results collection pod - collect-results.sh: for JFR debug pod Default remains docker.io busybox:1.37.0 for backward compatibility. Users can now override to use alternative registries: BUSYBOX_IMAGE="quay.io/quay/busybox:latest" ./scripts/run-benchmark.sh ... This is particularly useful for: - OpenShift/Red Hat environments (quay.io has better connectivity) - CI environments hitting Docker Hub rate limits - Air-gapped environments with local mirrors Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Keith Wall <kwall@apache.org>
SamBarker
force-pushed
the
feat/omb-kafka-metrics
branch
from
3b17c62 to
d1d36cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the busybox image used by result collection pods configurable via the
BUSYBOX_IMAGEenvironment variable, allowing users to avoid Docker Hub rate limits by using alternative registries.Problem
During testing on OpenShift, result collection failed due to Docker Hub rate limiting:
The busybox image was hardcoded in two places:
run-benchmark.sh- OMB results reader pod (collectsresult.jsonfrom PVC)collect-results.sh- JFR debug pod (collects JFR recordings from PVC)This blocked test completion even though the actual benchmark ran successfully and metrics were collected.
Solution
Added
BUSYBOX_IMAGEenvironment variable to both scripts with sensible defaults:BUSYBOX_IMAGE="${BUSYBOX_IMAGE:-busybox:1.37.0@sha256:b3255e7dfbcd10cb367af0d409747d511aeb66dfac98cf30e97e87e4207dd76f}"Users can now override to use alternative registries:
Quay.io (Red Hat):
BUSYBOX_IMAGE="quay.io/quay/busybox:latest" ./scripts/run-benchmark.sh ...GHCR (GitHub Container Registry):
BUSYBOX_IMAGE="ghcr.io/dockerhub-mirror/busybox:latest" ./scripts/run-benchmark.sh ...Benefits
Documentation
Added to Environment section in both scripts' usage:
Testing
Verified on OpenShift with:
BUSYBOX_IMAGE="quay.io/quay/busybox:latest"- successfully avoided rate limits🤖 Generated with Claude Code