Conversation
suisanka
marked this pull request as ready for review
August 2, 2026 10:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolveMilkyEvent(obj)at the root and@saltify/milky-tea/eventmittandeventsource, and mark the package side-effect freeWhy
The previous event subsystem duplicated connection state and transport forwarding while making consumers pay for code they may not use. Event delivery belongs to the host application; this package now focuses on validating and typing an already received Milky event.
The generated schema split keeps API validation and event parsing independently loadable. The event subpath avoids loading client metadata, while shared schemas remain deduplicated.
Breaking impact
client.event(),createMilkyEventSource(), and allMilkyEventSource*types are removedresolveMilkyEvent()Validation
pnpm typecheckpnpm test— 38 tests passedpnpm test:coverage— 97% statements, 89.92% branchespnpm exec eslint .pnpm check:bundlepnpm pack --dry-runBundle output now separates the 1.20 kB event entry, 11.81 kB event schema, 8.91 kB shared schema, and 41.55 kB API schema; the root runtime is reduced from 21.96 kB to 8.54 kB.