@W-23849761 | Validate translation locale filenames in 26.9 - #116
Closed
shauryemahajanSF wants to merge 3 commits into
Closed
shauryemahajanSF wants to merge 3 commits into
shauryemahajanSF wants to merge 3 commits into
Conversation
Move dash-case locale enforcement from packaged app configuration translations to the registry manifest translations where it belongs.
Retain dash-case validation for packaged app configuration translations while adding the registry manifest check.
Lock in dash-form locale enforcement for app configuration translations with an explicit regression test.
shauryemahajanSF
changed the title
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commerce-apps-manifest/translations/**changesapp-configuration/translations/dash-form validation and explicitly test that underscore filenames such aszh_CN.jsonare rejectedTest plan
bash .github/scripts/run-all-tests.shbash .github/scripts/test-validate-translations.shbash .github/scripts/validate-registry-translations.sh commerce-apps-manifest/translations.github/workflows/verify-zip.ymlwith Ruby YAML