Week6/sori m2#66
Open
soyun0318 wants to merge 21 commits into
Open
Conversation
feat: 1주차 미션
Feat: 2주차 미션1
Week2/sori m2
yewon20804
reviewed
May 14, 2026
Collaborator
yewon20804
left a comment
There was a problem hiding this comment.
6주차 2번째 미션도 수고하셨습니다 ! useInfiniteQuery 무한스크롤 + 스켈레톤 Ui를 진행해주셨는데요 ! 아래 코멘트 확인 부탁드립니다 👍
1. myPage.tsx — useState 초기값 타입 강제 캐스팅
// 현재
const [data, setData] = useState<ResponseMyInfoDto>([] as unknown as ResponseMyInfoDto);
// 수정
const [data, setData] = useState<ResponseMyInfoDto | null>(null);
배열 []을 as unknown as ResponseMyInfoDto 로 강제 캐스팅하면 초기 렌더링 시 data.data?.name 접근에서 런타임 에러가 발생할 수 있습니다! null 초기값 + optional chaining으로 처리해주는 게 안전합니다 !
2. 파일명 컨벤션 — myPage.tsx → MyPage.tsx
React 컴포넌트 파일은 PascalCase가 관례입니다! MyPage.tsx 로 변경하면 프로젝트 전반의 네이밍 컨벤션 일관성을 맞추기 더 좋을 것 같습니다 !
3. 이전 코멘트 내용
SignupPage.tsx — 사용하지 않는 임포트 2개
// 현재
import { data } from "react-router-dom";
import { is } from "zod/locales";
존재하지 않는 경로는 import 자체가 에러가 나기 때문에 지워주시면 좋을 것 같습니다 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 주차 / 미션
📌 작업 내용
✨ 상세 작업 내용
📸 스크린샷
❓ 리뷰어가 알아야 할 사항 / 질문
✅ 체크리스트