5주차 미션 [레인]#10
Open
geumbiii wants to merge 2 commits into
Open
Conversation
ywkim1m
approved these changes
May 5, 2026
|
|
||
| // 미션 생성 | ||
| export const createMission = async (req: Request, res: Response) => { | ||
| const { storeId, condition, rewardPoint } = req.body; |
Collaborator
There was a problem hiding this comment.
req.body 를 그대로 사용하기보다는 as UserSignUpRequest 와 같은 타입 단언으로 DTO 인터페이스를 입혀주세요!
DTO 추가 구현 해주시면 좋을 것 같습니다!
Collaborator
There was a problem hiding this comment.
Service에서 발생한 에러를 Controller에서 처리하지 않으면 서버가 종료될 수 있어 try-catch로 감싸는 것이 좋습니다!
전역 에러 핸들러를 사용하는 것도 괜찮습니다!
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5주차 미션
깃허브 이슈 생성(10th_Node.js에는 권한이 없어 개인 repository에서 생성)
bcrypt 설치
실습
1-1. 특정 지역에 가게 추가하기 API
1-2. 가게에 리뷰 추가하기 API
1-3. 가게에 미션 추가하기 API
1-4. 가게의 미션을 도전 중인 미션에 추가(미션 도전하기) API
3. 회원가입 API에 비밀번호 해싱 과정