Security updates

bin/banner.go

@@ -28,7 +28,7 @@ func doBanner() {
 	}
 	for _, line := range strings.Split(banner, "\n") {
 		if len(line) > 0 {
-			logging.Prelog(line)
+			logging.Prelog("%s", line)
 		}
 	}
 

bin/gui.go

@@ -72,7 +72,7 @@ func doGUI() error {
 		// client. It is useful for demonstration purposes and
 		// to just be able to use the notebook and build an
 		// offline collector.
-		logging.Prelog("No valid config found - " +
+		logging.Prelog("%s", "No valid config found - " +
 			"will generare a new one at <green>" + server_config_path)
 
 		config_obj = config.GetDefaultConfig()

bin/panic.go

@@ -61,5 +61,5 @@ func writeLogOnPanic() error {
 
 func FatalIfError(command *kingpin.CmdClause, cb func() error) {
 	err := cb()
-	kingpin.FatalIfError(err, command.FullCommand())
+	kingpin.FatalIfError(err, "%s", command.FullCommand())
 }

bin/query.go

@@ -206,7 +206,7 @@ func doRemoteQuery(
 		}
 
 		if response.Log != "" {
-			logger.Info(response.Log)
+			logger.Info("%s", response.Log)
 			continue
 		}
 

executor/executor.go

@@ -124,7 +124,7 @@ func (self *ClientExecutor) processRequestPlugin(
 		r := recover()
 		if r != nil {
 			logger := logging.GetLogger(config_obj, &logging.ClientComponent)
-			logger.Error(fmt.Sprintf("Panic %v: %v",
+			logger.Error("%s", fmt.Sprintf("Panic %v: %v",
 				r, string(debug.Stack())))
 		}
 	}()

file_store/directory/buffer.go

@@ -205,7 +205,7 @@ func (self *FileBasedRingBuffer) LeaseSerialized(count int) [][]byte {
 			return nil
 		})
 	if err != nil {
-		self.log_ctx.Error(err.Error())
+		self.log_ctx.Error("%s", err.Error())
 		return nil
 	}
 
@@ -223,7 +223,7 @@ func (self *FileBasedRingBuffer) Lease(count int) []*ordereddict.Dict {
 			return err
 		})
 	if err != nil {
-		self.log_ctx.Error(err.Error())
+		self.log_ctx.Error("%s", err.Error())
 		return nil
 	}
 	return result

flows/artifacts.go

@@ -734,7 +734,7 @@ func (self *FlowRunner) ProcessSingleMessage(
 				return nil
 			}
 
-			logger.Error(fmt.Sprintf("Unable to load flow %s: %v", job.SessionId, err))
+			logger.Error("%s", fmt.Sprintf("Unable to load flow %s: %v", job.SessionId, err))
 
 			client_manager, err := services.GetClientInfoManager(self.config_obj)
 			if err != nil {