Skip to content

Fix #50: correct implementation for redefined properties #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoineatstariongroup merged 1 commit into from
Jan 16, 2026
Merged

Fix #50: correct implementation for redefined properties #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
80 changes: 0 additions & 80 deletions ....NET.CodeGenerator.Tests/Expected/UML/Core/AutoGenDeSerializer/AssociationDeSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,26 +214,6 @@ internal static IAssociation DeSerialize(JsonElement jsonElement, SerializationM
logger.LogDebug("the elementId Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("endFeature"u8, out var endFeatureProperty))
{
foreach (var arrayItem in endFeatureProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var endFeatureExternalIdProperty))
{
var propertyValue = endFeatureExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.endFeature.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the endFeature Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("feature"u8, out var featureProperty))
{
foreach (var arrayItem in featureProperty.EnumerateArray())
Expand Down Expand Up @@ -1012,26 +992,6 @@ internal static IAssociation DeSerialize(JsonElement jsonElement, SerializationM
logger.LogDebug("the qualifiedName Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("relatedElement"u8, out var relatedElementProperty))
{
foreach (var arrayItem in relatedElementProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var relatedElementExternalIdProperty))
{
var propertyValue = relatedElementExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.relatedElement.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the relatedElement Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("relatedType"u8, out var relatedTypeProperty))
{
foreach (var arrayItem in relatedTypeProperty.EnumerateArray())
Expand Down Expand Up @@ -1061,26 +1021,6 @@ internal static IAssociation DeSerialize(JsonElement jsonElement, SerializationM
logger.LogDebug("the shortName Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("source"u8, out var sourceProperty))
{
foreach (var arrayItem in sourceProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var sourceExternalIdProperty))
{
var propertyValue = sourceExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Source.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the source Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("sourceType"u8, out var sourceTypeProperty))
{
if (sourceTypeProperty.ValueKind == JsonValueKind.Null)
Expand All @@ -1105,26 +1045,6 @@ internal static IAssociation DeSerialize(JsonElement jsonElement, SerializationM
logger.LogDebug("the sourceType Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("target"u8, out var targetProperty))
{
foreach (var arrayItem in targetProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var targetExternalIdProperty))
{
var propertyValue = targetExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Target.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the target Json property was not found in the Association: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("targetType"u8, out var targetTypeProperty))
{
foreach (var arrayItem in targetTypeProperty.EnumerateArray())
Expand Down
40 changes: 0 additions & 40 deletions ...2.NET.CodeGenerator.Tests/Expected/UML/Core/AutoGenDeSerializer/DependencyDeSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,26 +457,6 @@ internal static IDependency DeSerialize(JsonElement jsonElement, SerializationMo
logger.LogDebug("the shortName Json property was not found in the Dependency: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("source"u8, out var sourceProperty))
{
foreach (var arrayItem in sourceProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var sourceExternalIdProperty))
{
var propertyValue = sourceExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Source.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the source Json property was not found in the Dependency: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("supplier"u8, out var supplierProperty))
{
foreach (var arrayItem in supplierProperty.EnumerateArray())
Expand All @@ -497,26 +477,6 @@ internal static IDependency DeSerialize(JsonElement jsonElement, SerializationMo
logger.LogDebug("the supplier Json property was not found in the Dependency: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("target"u8, out var targetProperty))
{
foreach (var arrayItem in targetProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var targetExternalIdProperty))
{
var propertyValue = targetExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Target.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the target Json property was not found in the Dependency: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("textualRepresentation"u8, out var textualRepresentationProperty))
{
foreach (var arrayItem in textualRepresentationProperty.EnumerateArray())
Expand Down
20 changes: 0 additions & 20 deletions ...enerator.Tests/Expected/UML/Core/AutoGenDeSerializer/EnumerationDefinitionDeSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,26 +1597,6 @@ internal static IEnumerationDefinition DeSerialize(JsonElement jsonElement, Seri
logger.LogDebug("the usage Json property was not found in the EnumerationDefinition: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("variant"u8, out var variantProperty))
{
foreach (var arrayItem in variantProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var variantExternalIdProperty))
{
var propertyValue = variantExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.variant.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the variant Json property was not found in the EnumerationDefinition: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("variantMembership"u8, out var variantMembershipProperty))
{
foreach (var arrayItem in variantMembershipProperty.EnumerateArray())
Expand Down
114 changes: 0 additions & 114 deletions ...ET.CodeGenerator.Tests/Expected/UML/Core/AutoGenDeSerializer/FeatureTypingDeSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,31 +154,6 @@ internal static IFeatureTyping DeSerialize(JsonElement jsonElement, Serializatio
logger.LogDebug("the elementId Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("general"u8, out var generalProperty))
{
if (generalProperty.ValueKind == JsonValueKind.Null)
{
dtoInstance.General = Guid.Empty;
logger.LogDebug($"the FeatureTyping.General property was not found in the Json. The value is set to Guid.Empty");
}
else
{
if (generalProperty.TryGetProperty("@id"u8, out var generalExternalIdProperty))
{
var propertyValue = generalExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.General = Guid.Parse(propertyValue);
}
}
}
}
else
{
logger.LogDebug("the general Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("isImplied"u8, out var isImpliedProperty))
{
if (isImpliedProperty.ValueKind != JsonValueKind.Null)
Expand Down Expand Up @@ -448,30 +423,6 @@ internal static IFeatureTyping DeSerialize(JsonElement jsonElement, Serializatio
logger.LogDebug("the owningRelationship Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("owningType"u8, out var owningTypeProperty))
{
if (owningTypeProperty.ValueKind == JsonValueKind.Null)
{
dtoInstance.owningType = null;
}
else
{
if (owningTypeProperty.TryGetProperty("@id"u8, out var owningTypeExternalIdProperty))
{
var propertyValue = owningTypeExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.owningType = Guid.Parse(propertyValue);
}
}
}
}
else
{
logger.LogDebug("the owningType Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("qualifiedName"u8, out var qualifiedNameProperty))
{
dtoInstance.qualifiedName = qualifiedNameProperty.GetString();
Expand Down Expand Up @@ -510,71 +461,6 @@ internal static IFeatureTyping DeSerialize(JsonElement jsonElement, Serializatio
logger.LogDebug("the shortName Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("source"u8, out var sourceProperty))
{
foreach (var arrayItem in sourceProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var sourceExternalIdProperty))
{
var propertyValue = sourceExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Source.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the source Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("specific"u8, out var specificProperty))
{
if (specificProperty.ValueKind == JsonValueKind.Null)
{
dtoInstance.Specific = Guid.Empty;
logger.LogDebug($"the FeatureTyping.Specific property was not found in the Json. The value is set to Guid.Empty");
}
else
{
if (specificProperty.TryGetProperty("@id"u8, out var specificExternalIdProperty))
{
var propertyValue = specificExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Specific = Guid.Parse(propertyValue);
}
}
}
}
else
{
logger.LogDebug("the specific Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("target"u8, out var targetProperty))
{
foreach (var arrayItem in targetProperty.EnumerateArray())
{
if (arrayItem.TryGetProperty("@id"u8, out var targetExternalIdProperty))
{
var propertyValue = targetExternalIdProperty.GetString();

if (propertyValue != null)
{
dtoInstance.Target.Add(Guid.Parse(propertyValue));
}
}
}
}
else
{
logger.LogDebug("the target Json property was not found in the FeatureTyping: { Id }", dtoInstance.Id);
}

if (jsonElement.TryGetProperty("textualRepresentation"u8, out var textualRepresentationProperty))
{
foreach (var arrayItem in textualRepresentationProperty.EnumerateArray())
Expand Down
Loading
Loading