Skip to content

fix(config): name the next step in config init write errors #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
entelecheia merged 1 commit into from
Nov 10, 2026
Merged

fix(config): name the next step in config init write errors #128

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions internal/cli/configcmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ func writePrivateConfig(file string, data []byte, overwrite bool) error {
return fmt.Errorf("%s is owned by uid %d, not the user running this command; remove it or choose another --file", file, st.Uid)
}
} else if !os.IsNotExist(err) {
return fmt.Errorf("checking %s: %w", file, err)
return fmt.Errorf("checking %s: %w; check that its directory exists and you can read it, or choose another --file", file, err)
}
tmp, err := os.CreateTemp(filepath.Dir(file), ".rootfiles-config.*.tmp")
if err != nil {
Expand All @@ -210,7 +210,7 @@ func writePrivateConfig(file string, data []byte, overwrite bool) error {
fail := func(step string, err error) error {
_ = tmp.Close()
_ = os.Remove(tmpPath)
return fmt.Errorf("%s for %s: %w; the previous file, if any, is unchanged", step, file, err)
return fmt.Errorf("%s for %s: %w; the previous file, if any, is unchanged; check free space and write permission in %s, then rerun", step, file, err, filepath.Dir(file))
}
if err := tmp.Chmod(0600); err != nil {
return fail("setting mode 0600", err)
Expand All @@ -226,7 +226,7 @@ func writePrivateConfig(file string, data []byte, overwrite bool) error {
}
if err := os.Rename(tmpPath, file); err != nil {
_ = os.Remove(tmpPath)
return fmt.Errorf("replacing %s: %w; the previous file, if any, is unchanged", file, err)
return fmt.Errorf("replacing %s: %w; the previous file, if any, is unchanged; check write permission in %s, then rerun or choose another --file", file, err, filepath.Dir(file))
}
return nil
}
Loading