Skip to content

test(tenant): wait for loop release before remounting - #126

Merged
entelecheia merged 4 commits into
mainfrom
fix/117-tenant-mount-visibility
Nov 10, 2026
Merged

entelecheia merged 4 commits into
mainfrom
fix/117-tenant-mount-visibility

Conversation

@entelecheia

Copy link
Copy Markdown
Member

Closes #117

Copilot AI balanced review requested due to automatic review settings November 10, 2026 00:04

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@entelecheia entelecheia changed the title test(tenant): trace remount stop dependencies in CI test(tenant): wait for loop release before remounting Nov 10, 2026

Copy link
Copy Markdown
Member Author

Evidence and scope for the scenario-only change at 4e4b641c3c92d8784af0fc5cc41e9d72399d1f86:

  • Historical diagnostic job 129403022862 recorded a successful mount followed by another unmount, inactive/dead with Result=success, and the path on the parent filesystem before Docker start. The final stop requester is not identified by that log; it does not prove a daemon-only namespace problem or data deletion.
  • The first 25-trial diagnostic at 6a859fc passed five trials, then hit the start limiter. That was a harness artifact. With pacing, job 129546150243 at 744c1da passed 82/82, including 25/25 remount trials. The original loop-event hypothesis remains unproven.
  • The new scenario records the old loop devices, stops the unit, waits up to about 30 seconds for udev to settle, losetup -j to be empty and the old device units to be inactive, then starts the mount. Probe errors/timeouts are fatal before start; existing image identity, UUID and data checks remain. No formatting, directory population or repair retry is added. The first post-growth trial remains immediate; later trials retain pacing.
  • Production MountUnit generation/options and all internal/tenant code are unchanged. The owning spec now states the resulting scenario contract; investigation history is retained here.

Local static checks passed: bash -n, warning-level ShellCheck, workflow/source diff checks and specs (21, 0 errors). No scenario was run locally or on a non-CI host. Exact-head hosted CI and one additional tenant-scenario run on the same head are still required before this draft is ready.

@entelecheia
entelecheia marked this pull request as ready for review November 10, 2026 10:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T10:29:44.856831Z 4e4b641 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@entelecheia
entelecheia merged commit c407558 into main Nov 10, 2026
112 of 114 checks passed
@entelecheia
entelecheia deleted the fix/117-tenant-mount-visibility branch November 10, 2026 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(tenant): diagnose data mount visibility after mount-unit restart

2 participants