Skip to content

fix: prevent partial ItemRef picture substitution #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
entelecheia merged 4 commits into from
Nov 10, 2026
Merged

fix: prevent partial ItemRef picture substitution #494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5950a5
test: expose partial ItemRef picture misbinding
entelecheia Nov 10, 2026
a0ec9d2
docs: translate HWP5 writer comments to English
entelecheia Nov 10, 2026
c6d7f6d
fix: resolve ItemRefs by exact model name rules
entelecheia Nov 10, 2026
03b0d63
docs: record exact ItemRef picture resolution
entelecheia Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@ The workspace `Cargo.toml` `[workspace.package] version` is the single source fo

**Fixed**

- HWP5 picture synthesis resolves unlisted `ItemRef` values with the model's case-sensitive
exact name, path-suffix and filename-stem rules. Partial names such as `image1` no longer
select `image10.png`; unresolved references report `BinaryAssetRemoved` instead of embedding
another picture. Manifest precedence and native `BinRef::Id` compatibility are preserved
([#453](https://github.com/STAIxBWLB/hwp-cli/issues/453)).

- A numbering template containing `<`, `>` or `&` now survives HWPX output. The HWPX reader
resolves the XML entity references (`&lt;`, `&gt;`, `&amp;`) inside `paraHead` text instead of
dropping them, so `hwp compose` writes an ordered-list marker such as `<{n}>` escaped and
Expand Down
Loading
Loading