Repository navigation
test(cli): isolate JSON goldens from agent profile roots - #408
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
entelecheia
added a commit
that referenced
this pull request
Nov 9, 2026
entelecheia
added a commit
that referenced
this pull request
Nov 9, 2026
* chore(release): add v2.81.0 release notes Covers #399, #400, #401, #402, #404, #405, #407 and #409. #406 (spec docs) and #408 (test isolation) are left out per the release-note rules. Claude-Session: https://claude.ai/code/session_01Vb48Vt5iGMfc7MJWPTCWCL * chore(release): v2.81.0 notes, apply review findings Name the resume reload fix (#411), the peer pair upgrade, the exact anchor scope, the dot sync target change and the dot admit wait. Claude-Session: https://claude.ai/code/session_01Vb48Vt5iGMfc7MJWPTCWCL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #403
Keep ai policy JSON golden cases inside their fixture profiles by clearing inherited
CLAUDE_CONFIG_DIR,CODEX_HOME,KIMI_CODE_HOMEandOPENCODE_CONFIG_DIRbefore fixture setup. The existing fixture still setsHOMEandXDG_CONFIG_HOME; the cases remain serial, andt.Setenvrestores each variable after its subtest.This changes only
internal/cli/json_golden_test.go. Product behavior and golden files are unchanged.Validation at
a96acee19b013647380e757521d715ec058d1344:dot admit -- env CLAUDE_CONFIG_DIR=/tmp/elsewhere GOMAXPROCS=2 go test -p 2 -count=1 -run TestJSONGoldens ./internal/cli/: passed.dot admit -- env -u CLAUDE_CONFIG_DIR GOMAXPROCS=2 go test -p 2 -count=1 -run TestJSONGoldens ./internal/cli/: passed.git diff origin/main...HEAD --name-only: onlyinternal/cli/json_golden_test.go; no golden changes.