Repository navigation
fix(workspace): replace a dangling symlink before recreating it - #399
Merged
Merged
Conversation
`dot apply` failed with EEXIST when a managed link existed but its target was gone (seen after the cloud mirror moved): Check planned the relink, then os.Symlink hit the stale link still sitting at the path. Apply now removes such a path first, but only when it is a symlink whose target is missing, at all four federation sites (workspace path, cloud symlink, work/.gdrive, inbox links). Real files, real directories and links whose target exists stay untouched, and a dry run removes nothing.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ce4592189
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
entelecheia
added a commit
that referenced
this pull request
Nov 9, 2026
entelecheia
added a commit
that referenced
this pull request
Nov 9, 2026
* chore(release): add v2.81.0 release notes Covers #399, #400, #401, #402, #404, #405, #407 and #409. #406 (spec docs) and #408 (test isolation) are left out per the release-note rules. Claude-Session: https://claude.ai/code/session_01Vb48Vt5iGMfc7MJWPTCWCL * chore(release): v2.81.0 notes, apply review findings Name the resume reload fix (#411), the peer pair upgrade, the exact anchor scope, the dot sync target change and the dot admit wait. Claude-Session: https://claude.ai/code/session_01Vb48Vt5iGMfc7MJWPTCWCL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #398
Release note:
dot applyno longer fails withfile existswhen a workspace symlink points at a target that moved; it replaces the stale link.