Repository navigation
test(sync): size activation cadence budgets from hosted phase evidence - #361
Merged
Merged
Conversation
entelecheia
marked this pull request as ready for review
November 10, 2026 15:42
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #345.
The person-activation functional e2e now passes
syncDeadlineMs: 60_000through the existing context seam only for its two expected-success forced cadence calls. 60 seconds exceeds twice the slowest observed completed full sync in the captured hosted macOS job (28.554 seconds). Those child envelopes are 90 seconds, leaving 30 seconds for startup/stop/cleanup; all other child envelopes remain 60 seconds. The named test envelope is 240 seconds for two cadence budgets plus activation, plain sync and cleanup. The diagnostic asserts both overridden calls actually observed 60 seconds.Every existing writer-drift, floor, backoff, remote-row and exact-marker assertion remains. There is no retry or relaxed result assertion, no product source change, no CLI flag, and no change to the product's 30-second default or stop/retention/fail-closed behavior.
The captured failure at head 0a6bcc2, hosted macOS job129793329365, established call12's own deadline, not a cumulative budget from earlier calls:
At before-CAS, 94.912% of the budget had elapsed and only 1.526 seconds nominally remained. The marker precedes installed-object/final guards and the actual push, and no CAS-returned/ack/import/receipt marker was observed. Therefore the actual remote effect is unmeasured; the returned
ok:false,outcome:unknownand retained attempt are the correct conservative response. Earlier calls10 and11 took 5.033 and10.314 seconds independently and did not consume call12's timer. These phase spans do not isolate a syscall, device or scheduler cause.A focused real-deadline fixture regression aborts after durable publication intent, proves false/unknown with an unchanged retained plan and intent, no completed receipt or remote refs, and then resumes that same plan successfully. Existing sync-cadence deadline/group/backoff tests remain unchanged.
Product-level follow-up observation only: a full placement sync can take about 30 seconds on a slow hosted runner (plain call3 completed in28.554 seconds). No product action on that observation is included here.
Validation status: implementation head 7b0f87f is supplied as a draft for hosted CI. No product source diff and diff-check is clean. The initial remote typecheck at b6f63eb failed only on a shared/non-shared Buffer expectation type; byte comparisons were changed to
Buffer.equals()without changing their meaning. Final-head typecheck, boundary, focused/full tests (including the new deadline regression) and pack are unverified: retry admission was deferred with three, then four other verify jobs against the cap of three. No extra run or heavy Mac fallback was started. Hosted CI must validate this head before acceptance. The issue stays open until 10 hosted macOS passes after the fix are recorded; that evidence is not claimed by this PR.