Repository navigation
feat(space): refit Room around compact avatars and popovers - #109
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17ff4f6e60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Leaving a hovered avatar no longer closes its popover at once: a 150 ms grace period lets the pointer cross the gap, and entering the popover or the avatar cancels it. Leaving both closes the popover; a still-focused avatar keeps restoring its own popover immediately.
Pinch-zoom panning scrolls the visual viewport without resizing it, so the open popover also listens to visualViewport scroll to re-clamp or close when its invoker leaves view; the listener is removed on close.
- Cap the popover height to the larger free side of its invoker and place it there, so a long popover never covers the avatar and blocks the click that opens its detail. - Close the popover when its invoker is scrolled out of the scene scroller, not only out of the viewport.
…text A snapshot route still fetching when its probe closed the browser context rejected with 'Request context disposed' and aborted the whole run. That teardown race is now ignored; other unhandled rejections still fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Room currently uses tall actor cards and leaves much of the viewport unused. This implements delivery 5 of #101: Room fills the available column below shell/Space controls, with only its scene scrolling. Compact avatars/two-line names replace expanded actor cards. Hover/focus opens a viewport-clamped Team-facts tooltip; click/Enter opens detail, Back restores focus, and Escape dismisses the tooltip.
Long descriptions scroll vertically without taking focus from the avatar. Wheel, arrows, PageUp/PageDown and Home/End make every fact reachable at enlarged text or short viewport heights. Switching actors starts the description at the beginning. While open, window and visualViewport resize events reposition it against the current visible viewport, including height-only changes. If the invoker leaves view the tooltip hides; closing, hiding the renderer or destroying it removes both listeners. CSS Room derives billboard spacing from measured extents, preserves Flat/Room relationship endpoints, and keeps the existing lazy WebGL overlay/fallback behavior. Team is the visible text alternative; Room retains a non-focusable screen-reader summary.
Pet inventory ids participate in Team/Flow/Board/Room/detail/popover memo signatures. Existing tokens provide consistent state colors, radius/spacing and working dots, disabled for stale data or reduced motion.
Probe alignment:
Validation at
3fff66f70377a2b02d952ced3ecc095337492ef3:Related to #101. Server cache and producer changes are outside this PR.