Skip to content

feat(space): add Board view and avoid unchanged Team geometry writes - #107

Merged
entelecheia merged 2 commits into
mainfrom
feat/101-space-board
Nov 10, 2026
Merged

entelecheia merged 2 commits into
mainfrom
feat/101-space-board

Conversation

@entelecheia

@entelecheia entelecheia commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Board currently shows a placeholder. This implements delivery 4 of #101 with per-group columns based on producer zones, producer-linked cards with tone and owner controls, and Done history showing the last five supplied cards. Every column preserves the producer-reported zone total and labels the supplied/filtered card count when it differs. Earlier Done cards expand through a disclosure. Each row owns its horizontal scroll; group/state filters, ungrouped work, focus keys, disclosure state and scroll positions are preserved. Owner controls open the existing actor detail. Both serving modes include the new module.

The pre-existing Team mutation has a real renderer path: initial or changed-width ResizeObserver delivery forced update(lastModel, true) even with unchanged Team facts. A deterministic regression reproduced ten counted attribute writes in the DOM fixture, consistent with the browser finding's additional reflected/dataset mutations. Geometry-driven updates now run only for Room; Team, Flow and Board use CSS layout. The Team probe additionally waits for both fixture producers and removes CSP-incompatible predicate waits. Exact macOS flake elimination remains subject to reviewer browser execution.

README and CHANGELOG describe Board and the resize fix. The README also corrects the snapshot-cache wording from the preceding PR: successful Space replies keep their existing allowlisted projection, which omits producer top-level stale/sample-time fields.

Validation at fec65df26de5b563023ec0a3340e6ba6cb0cf772:

  • Frozen install passed. Focused Space/public/design tests: 73 passed on this head, including mismatched totals in Done and Work before/after filtering, with disclosure math based only on supplied cards. Earlier static-build and published 0.1.8 compatibility tests: 22 passed.
  • Main and N-1 type checks, boundary, README facts, JavaScript syntax and diff checks passed. Documentation freshness still emits two non-blocking stamp warnings; stamps are unchanged.
  • New Board probe covers the 16 viewport/theme/text combinations, Done total20/supplied7 with 5/7 disclosure behavior, keyboard producer navigation, unchanged writes and local horizontal scroll. Browser execution and OCR are pending reviewer verification. Full check remains hosted-CI work per assignment.

Related to #101. Room refit, server-cache changes and producer changes remain separate.

Copilot AI balanced review requested due to automatic review settings November 10, 2026 13:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T13:12:38.500921Z 6451f9b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6451f9b7f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread shell/space-board.js Resolved
@entelecheia
entelecheia merged commit 488416a into main Nov 10, 2026
3 checks passed
@entelecheia
entelecheia deleted the feat/101-space-board branch November 10, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants