Repository navigation
feat(space): add Board view and avoid unchanged Team geometry writes - #107
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6451f9b7f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Board currently shows a placeholder. This implements delivery 4 of #101 with per-group columns based on producer zones, producer-linked cards with tone and owner controls, and Done history showing the last five supplied cards. Every column preserves the producer-reported zone total and labels the supplied/filtered card count when it differs. Earlier Done cards expand through a disclosure. Each row owns its horizontal scroll; group/state filters, ungrouped work, focus keys, disclosure state and scroll positions are preserved. Owner controls open the existing actor detail. Both serving modes include the new module.
The pre-existing Team mutation has a real renderer path: initial or changed-width ResizeObserver delivery forced
update(lastModel, true)even with unchanged Team facts. A deterministic regression reproduced ten counted attribute writes in the DOM fixture, consistent with the browser finding's additional reflected/dataset mutations. Geometry-driven updates now run only for Room; Team, Flow and Board use CSS layout. The Team probe additionally waits for both fixture producers and removes CSP-incompatible predicate waits. Exact macOS flake elimination remains subject to reviewer browser execution.README and CHANGELOG describe Board and the resize fix. The README also corrects the snapshot-cache wording from the preceding PR: successful Space replies keep their existing allowlisted projection, which omits producer top-level stale/sample-time fields.
Validation at
fec65df26de5b563023ec0a3340e6ba6cb0cf772:Related to #101. Room refit, server-cache changes and producer changes remain separate.