Repository navigation
feat: add default Space Team view and agent detail - #103
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 225ec4a4fe
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…eader - Make every Space root child except the detail inert while it is open, so Room scene-style and camera controls cannot take focus behind it. - Fall back to the section tab when a focused Team control disappears. - Store the section choice under acon.space.section; acon.space.view stays a read-only legacy scene-style input. - Let the Space header scroll with the page; the sticky header covered scene controls at 200% text and narrow widths. - ui-check: wait for the hidden detail state and run the raised-cap performance probe in a CSP-bypassing context.
- Re-apply inert after the lazy Room controller adds its controls, so a direct room&actor route cannot leave scene-style buttons operable. - When the Space area is entered with an open detail (for example Back from a producer panel), move focus to the detail's Back control so Escape and the Tab trap work again. - README: actors open their detail; cards navigate to their panel.
- Record and restore .column scrollTop, the page scroller at compact widths, when an actor detail closes after a producer round trip. - A state filter keeps each kept actor's current card even when the card has no owner or another owner, so Team keeps the task title. - ui-check: compact producer -> Back -> Escape restores scroll and focus.
Team now shows '(last reported, stale)' and a dashed border for actors whose source failed to refresh, matching Room and the actor detail.
A Team Board/Flow shortcut hid the Team section while focus stayed on the hidden shortcut. Focus now moves to the selected section tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Space now opens on Team unless the route or a saved view choice selects another section. Team puts blocked, waiting and approval-holding actors under Needs attention, then shows grouped active tiles and collapsed idle/away agents. Each tile keeps the public name, 40 px pet, roles, state glyph/text, two-line task title and inbox/approval badges. Room keeps its existing roster and scene controls.
Agent detail uses actor=, opens from Team or Room by keyboard/click, and uses a side sheet at 1024 px and wider or a full page below. It shows source-owned group/roles/state/since, current task with its producer link, marks and current overlap/conflict/cohort partners. Interactions explicitly says history appears once observed; no activity buffer is added. Open in follows the actor's existing link. Escape/Back closes an invoked detail through history and restores its actor focus and scroll; direct unknown keys show a cause and next step. Detail traps Tab and makes its Space background inert while open. Unchanged public snapshots do no Team/detail DOM writes. Changed snapshots retain focus by distinct stable keys for detail Back/task/Open-in controls and Team attention/tile/shortcut/resting controls. A removed detail control falls back to Back; Tab recovers focus from body after focus loss, while native dialogs and controls outside actor detail retain keyboard ownership. Closed resting disclosures receive focus on their visible summary instead of a hidden actor tile; removed controls fall back to the Space section tab. Failed first-poll sources are settled, so the existing failed/stale notice and unknown actor/group remedies replace indefinite waiting.
Carried PR 1 fixes:
The new private space-team.js file is included in the existing trusted H1 shell file map and H2 static package. No contract change, runtime dependency, authority-bearing state, Flow buffer, Board content, Room refit or producer change. README/CHANGELOG updated; docs/verified.json untouched.
Refs #101, Delivery 2 only. Later deliveries finish Flow, Board and Room refit.
Validation at d2e3284, based on main 83b835b:
No merge, deployment or release.